Fix: add namespace to PVC rules to avoid many-to-many joins#131
Closed
BenjaminBanwart wants to merge 1 commit intoopenebs:developfrom
Closed
Fix: add namespace to PVC rules to avoid many-to-many joins#131BenjaminBanwart wants to merge 1 commit intoopenebs:developfrom
BenjaminBanwart wants to merge 1 commit intoopenebs:developfrom
Conversation
Contributor
Author
abhilashshetty04
approved these changes
May 21, 2025
Abhinandan-Purkait
approved these changes
May 21, 2025
Contributor
Author
|
Is there an estimate on a timeline for getting this into a release? |
Member
|
Hi, This should be along with OpenEBS v4.3 |
Member
|
@BenjaminBanwart Can you please squash your commits. |
Signed-off-by: Benji Banwart <70287143+BenjaminBanwart@users.noreply.github.com> fix/ update expression in jsonnet dir Signed-off-by: Benji Banwart <70287143+BenjaminBanwart@users.noreply.github.com> fix/ implement count by() on the right side of the expression The count by() returns one series per claim. This makes the join key unique on both sides. Signed-off-by: Benji Banwart <70287143+BenjaminBanwart@users.noreply.github.com> fix/ simplify and fix the expression here introduce count by() to allow for unique join keys Signed-off-by: Benji Banwart <70287143+BenjaminBanwart@users.noreply.github.com> fix: add namespace to PVC joins Avoid many-to-many errors when the same PVC name exists in multiple namespaces by joining on namespace.
BenjaminBanwart
force-pushed
the
fix/namespace-in-pvc-prom-rules
branch
from
83d37aa to
d73936e
Compare
Member
|
Cherry-picked: #132 |
Contributor
Author
|
@abhilashshetty04 No problem, thanks for getting this in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Prometheus alerting rules for detecting unconsumed Persistent Volume Claims (PVCs) to improve accuracy and maintain consistency across configurations.
This ensures that PVC's with the same labels in different namespaces will not cause duplication errors.
Changes to Prometheus alerting rules:
exprfield indeploy/charts/rules/volume/volume-rules.jsonto useUNLESS ON (namespace, persistentvolumeclaim)withcount by (namespace, persistentvolumeclaim)for better alignment with Prometheus query language best practices.exprfield injsonnet/openebs-mixin/rules/volume/volume-rules.libsonnetto ensure consistency with the JSON configuration.