Skip to content

Conversation

@brianneville
Copy link
Contributor

gnoi v0.8.0 changed the way that some errors
are reported, so that they use error statuses
instead of custom error message/enum types.

This commit updates the handling for RemoveImage,
StartContainer/UpdateContainer RPCs so that they
no longer use the outdated types.

openconfig/gnoi#317
in gnoi v0.8.0 changed the way that some errors
are reported, so that they use error statuses
instead of custom error message/enum types.

This commit updates the handling for RemoveImage,
StartContainer/UpdateContainer RPCs so that they
no longer use the outdated types.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 21224490867

Details

  • 5 of 11 (45.45%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 63.371%

Changes Missing Coverage Covered Lines Changed/Added Lines %
client/start_container.go 0 2 0.0%
client/update_container.go 0 2 0.0%
server/remove_image.go 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
client/start_container.go 1 79.13%
client/update_container.go 1 74.07%
Totals Coverage Status
Change from base Build 21191943387: -0.01%
Covered Lines: 1692
Relevant Lines: 2670

💛 - Coveralls

@alshabib
Copy link
Collaborator

Can you resolve the conflicts here?

@brianneville
Copy link
Contributor Author

resolved conflicts now.

@brianneville
Copy link
Contributor Author

btw just a heads up but the deps update https://github.com/openconfig/containerz/pull/56/checks ran without passing any of the build/test CI checks that are required for normal PRs, meaning it was able to update to the gnoi v0.8.0 version, despite the fact that this repo has compilation errors for that version of gnoi (due to message types being removed).

I imagine there are downsides to letting a bot trigger CI runs (potentially you've already considered these and already decided to not let renovate run CI checks), and in reality these kind of breaking changes shouldnt happen too often (fingers crossed).
So maybe its fine to leave the renovate PRs as-is without the extra checks - im just bringing it to your attention since they can break the repo like this

@alshabib alshabib merged commit 34a627f into openconfig:master Jan 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants