store Location field as a label on started containers #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note: this PR includes the changes from #58 |
brianneville
force-pushed
the
label-location
branch
from
7b67ab1 to
dd9bbf3
Compare
Pull Request Test Coverage Report for Build 21675251830Details
💛 - Coveralls |
brianneville
changed the title
brianneville
force-pushed
the
label-location
branch
from
dd9bbf3 to
89914a3
Compare
alshabib
reviewed
Jan 28, 2026
alshabib
approved these changes
Jan 28, 2026
Collaborator
|
This needs a rebase as well and then it can be submitted. |
Store the location field from the StartContainer/UpdateContainer messages as a label on the started container. if the label is unspecified (L_UNKNOWN) then it is treated as L_PRIMARY as a default.
brianneville
force-pushed
the
label-location
branch
from
89914a3 to
dfcbf2c
Compare
alshabib
reviewed
Feb 4, 2026
also update comment to have the correct function name, and to note that we're really updating the labels map, and not actually building the entire map from scratch. (i.e. we won't modify any existing labels in the map).
alshabib
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the location field from the
StartContainer/UpdateContainer messages
as a label on the started container.
if the label is unspecified (L_UNKNOWN) then
it is treated as L_PRIMARY as a default.