Skip to content

docs: improve docs for download link option #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samuelallan72 merged 1 commit into from
Aug 21, 2025
Merged

docs: improve docs for download link option #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pdf/templates/html/pdf_edit.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@
{% if not disable_all_download %}
<li class="field comp-setting-entry is-set">
<div class="wrapper-comp-setting">
<label class="label setting-label" for="pdf_edit_allow_download">{% trans "PDF Download Allowed" %}</label>
<label class="label setting-label" for="pdf_edit_allow_download">{% trans "Show PDF download link" %}</label>
<select class="input setting-input" id="pdf_edit_allow_download">
<option value="True" {% if allow_download %}selected{% endif %}>{% trans "True" %}</option>
<option value="False" {% if not allow_download %}selected{% endif %}>{% trans "False" %}</option>
</select>
</div>
<span class="tip setting-help">{% trans "Display a download button for this PDF." %}</span>
<span class="tip setting-help">{% trans "Display a download link to this PDF for convenience. Please note that even if this is disabled, the embedded PDF viewer may still display its own download button." %}</span>
</li>

<li class="field comp-setting-entry is-set">
Expand Down
3 changes: 2 additions & 1 deletion pdf/templates/html/pdf_view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ <h2>{{ display_name }}</h2>
<ul>
{% if allow_download %}
<li class="pdf-download-button">
<a href="{{ url }}" download>{% trans "Download the PDF" %}</a>
<a href="{{ url }}" target="_blank" rel="noopener" download>{% trans "Download the PDF" %}</a>
(Right click or long press on the download link and select the "Save as" option to download. Clicking on the link might open it in a tab.)
</li>
{% endif %}
{% if source_url != "" %}
Expand Down
Loading