docs: improve docs for download link option #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify that the embedded pdf viewer in the browser may also display a download button, regardless of this option. Also improve the student-facing behaviour of the download button: - add help text for how to download - make the link open in a new tab so students won't lose their place in the course. Private-ref: https://tasks.opencraft.com/browse/BB-9935
xitij2000
approved these changes
Aug 20, 2025
Member
Author
|
Thanks @xitij2000 :) Note that I'm ignoring the failing pylint tests in CI, because I didn't change any python files and the target branch has the same error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clarify that the embedded pdf viewer in the browser may also display a download button, regardless of this option. Also improve the student-facing behaviour of the download button:
Supporting information
Private-ref: https://tasks.opencraft.com/browse/BB-9935
Testing instructions