Skip to content

refactor: remove not exist event #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leavesster merged 1 commit into from
Jul 29, 2025
Merged

refactor: remove not exist event #422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions oocana/oocana/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from dataclasses import asdict
from .data import BlockInfo, StoreKey, JobDict, BlockDict, BinValueDict, VarValueDict
from .mainframe import Mainframe
from .handle import HandleDef, OutputHandleDef
from .handle import OutputHandleDef
from typing import Dict, Any, TypedDict, Optional, Callable, Mapping, Literal
from types import MappingProxyType
from base64 import b64encode
Expand Down Expand Up @@ -833,10 +833,6 @@ def event_callback(payload: Dict[str, Any]):
progress = payload.get("progress")
if progress is not None:
run_progress_callback(progress)
Copy link

Copilot AI Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the SubflowBlockProgress event handler creates inconsistent event handling. If SubflowBlockFinished events exist, there should likely be corresponding SubflowBlockProgress events. Consider verifying that SubflowBlockProgress events truly don't exist or documenting why only the finished event is handled.

Suggested change
run_progress_callback(progress)
run_progress_callback(progress)
elif payload.get("type") == "SubflowBlockProgress":
progress = payload.get("progress")
if progress is not None:
run_progress_callback(progress)

Copilot uses AI. Check for mistakes.
elif payload.get("type") == "SubflowBlockProgress":
progress = payload.get("progress")
if progress is not None:
run_progress_callback(progress)
elif payload.get("type") == "SubflowBlockFinished":
error = payload.get("error")
if error is None:
Expand Down
Loading