refactor: remove not exist event #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes handling for a non-existent "SubflowBlockProgress" event type and an unused import. The refactoring simplifies the event handling logic by eliminating redundant code that was processing the same progress callback for both "BlockProgress" and "SubflowBlockProgress" events.
- Removed unused
HandleDefimport from the handle module - Eliminated duplicate event handling for "SubflowBlockProgress" event type
| elif payload.get("type") == "BlockProgress": | ||
| progress = payload.get("progress") | ||
| if progress is not None: | ||
| run_progress_callback(progress) |
There was a problem hiding this comment.
The removal of the SubflowBlockProgress event handler creates inconsistent event handling. If SubflowBlockFinished events exist, there should likely be corresponding SubflowBlockProgress events. Consider verifying that SubflowBlockProgress events truly don't exist or documenting why only the finished event is handled.
Suggested change
| run_progress_callback(progress) | |
| run_progress_callback(progress) | |
| elif payload.get("type") == "SubflowBlockProgress": | |
| progress = payload.get("progress") | |
| if progress is not None: | |
| run_progress_callback(progress) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.