UI: Disable incompatible codecs in settings

[derrod]

Description

Disable codecs that are incompatible based on the container drop down state. If an incompatible codec is selected when changing container, the encoder selection is reset to an invalid state and a warning is shown.

Screenshot:

Motivation and Context

Wanted to avoid having to add more warnings for Opus and #8289

How Has This Been Tested?

Selected different contaiers, ensured codecs got disabled as necessary. Also tested with #8289 and made sure that works correctly.

Types of changes

• New feature (non-breaking change which adds functionality)

Checklist:

• My code has been run through clang-format.
• I have read the contributing document.
• My code is not on the master branch.
• The code has been tested.
• All commit messages are properly formatted and commits squashed where appropriate.
• I have included updates to all appropriate documentation.

[notr1ch]

I think it might be nicer if the container was always shown in uppercase in the incompatible warning.

[derrod]

I think it might be nicer if the container was always shown in uppercase in the incompatible warning.

Sure that can be done. See the updated screenshot.

[derrod]

OK'd by @Warchamp7 off-thread, looking to merge during weekly PR review.

[derrod]

Based on feedback from @Warchamp7 the following changes have been implemented:

• When an invalid codec is selected, the selection is now set to "nothing" (-1) and a placeholder text is shown
• A warning is visible as long as either encoder selection is invalid
• The same behaviour now applies to simple mode as long as recording encoders are used
• When using stream encoders in simple mode incompatible containers are disabled instead

See updated screenshots for the placeholder and warning.

[notr1ch]

Closing the settings without picking a replacement encoder seems to stop recording from functioning at all (not even anything in the log file). After re-opening settings, there is no obvious error as the list index is reset to "Use stream encoder" (but internally not).

obs64_a0x0QHCsTD.mp4

[derrod]

Should be fixed now. Apparently the way the comboboxes are restored is slightly different so this only affected the audio one. Affects both, will push fix in a minute.