Skip to content

VAN-2899 | Update applicationName with deploymentName in templates#73

Open
akashcldcvr wants to merge 3 commits intomasterfrom
akashj/VAN-2899
Open

VAN-2899 | Update applicationName with deploymentName in templates#73
akashcldcvr wants to merge 3 commits intomasterfrom
akashj/VAN-2899

Conversation

@akashcldcvr
Copy link
Contributor

VAN-2772 | Replace applicationName with deploymentName in all template

Copy link
Contributor

@shwetanshu-cldcvr shwetanshu-cldcvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shwetanshu-cldcvr shwetanshu-cldcvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kanaksinghal
Copy link

This change is not expected to be backward compatible as the existing services will now not be manageable since the service name we'd try to un-deploy/re-deploy would be different.
So we'll need to strategies the release for this. And hold the merge till then.

@dshelley66
Copy link
Contributor

@akashcldcvr @kanaksinghal did we ever figure out what we were going to do with this work?

@kanaksinghal
Copy link

@akashcldcvr @kanaksinghal did we ever figure out what we were going to do with this work?

No, here's what we need to do:

  • Figure out migration.
    • Since this issue is in specific deployment template,
    • we can actually create a new template
    • Add "deprecated" to the title of old template
    • release these changes
    • migrate all users to new template by undeploy->deploy on user's convenience
    • then remove old template.
  • I think PR is too old now anyway, so we should close this, agree on a plan and then open new PR.

@shwetanshu-cldcvr @akashcldcvr @dshelley66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants