VAN-2899 | Update applicationName with deploymentName in templates#73
Open
akashcldcvr wants to merge 3 commits intomasterfrom
Open
VAN-2899 | Update applicationName with deploymentName in templates#73akashcldcvr wants to merge 3 commits intomasterfrom
akashcldcvr wants to merge 3 commits intomasterfrom
Conversation
29566db to
a760daa
Compare
|
This change is not expected to be backward compatible as the existing services will now not be manageable since the service name we'd try to un-deploy/re-deploy would be different. |
Contributor
|
@akashcldcvr @kanaksinghal did we ever figure out what we were going to do with this work? |
No, here's what we need to do:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VAN-2772 | Replace applicationName with deploymentName in all template