Skip to content

VAN-2772 | Update applicationName with deploymentName in templates#72

Closed
akashcldcvr wants to merge 2 commits intomasterfrom
akashj/VAN-2772
Closed

VAN-2772 | Update applicationName with deploymentName in templates#72
akashcldcvr wants to merge 2 commits intomasterfrom
akashj/VAN-2772

Conversation

@akashcldcvr
Copy link
Contributor

VAN-2772 | Replace applicationName with deploymentName in all template

Copy link
Contributor

@shwetanshu-cldcvr shwetanshu-cldcvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akashcldcvr akashcldcvr changed the title VAN-2772 | Replace applicationName with deploymentName VAN-2772 | Update applicationName with deploymentName in templates Aug 1, 2022
@kanaksinghal
Copy link

@akashcldcvr This is VN-2772 not VAN-2772. VN: frontend board, VAN: backend board.

Since then VN-2772 ticket doesn't give much context of the work done in this change, I created another ticket: VAN-2899.

Hoping we can use VAN-2899 for PR, branch & commit.

@akashcldcvr
Copy link
Contributor Author

Closing the PR , create new PR for thsi changes as suggested by the @kanaksinghal
#73

@akashcldcvr akashcldcvr closed this Aug 2, 2022
@akashcldcvr akashcldcvr deleted the akashj/VAN-2772 branch August 2, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants