Skip to content

Fix sentence case ESLint config for Obsidian review bot compliance #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nilsandrey merged 6 commits into from
Mar 10, 2026
+8 −8
Merged

Fix sentence case ESLint config for Obsidian review bot compliance #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d3c8220
Initial plan
Copilot Mar 9, 2026
2d0d227
Initial plan: fix sentence case UI text issues
Copilot Mar 9, 2026
a846cf1
fix: clean up sentence case ESLint config - remove redundant GUIDs fr…
Copilot Mar 9, 2026
065eff6
Fix typo in description for uppercase hex digits
nilsandrey Mar 10, 2026
a2e9073
Correct spelling of 'GUIDs' to 'Guids'
nilsandrey Mar 10, 2026
6765633
Update timestamp command names to lowercase
nilsandrey Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ export default defineConfig([
"obsidianmd/ui/sentence-case": [
"error",
{
// Preserve these proper nouns/acronyms that are not in the default list
ignoreWords: ["UTC", "ISO", "Unix", "GUIDs"],
// These proper nouns and acronyms are not in the plugin's default list
ignoreWords: ["UTC", "ISO", "Unix"],
Comment on lines +21 to +22
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR’s description currently doesn’t include the required changelog markers / version-bump checkbox section used by the release workflow ( and with exactly one box checked). Without that, merging to main will cause the Release workflow to fail with “No version bump checkbox selected”. Please update the PR description to match the repository template so releases can be generated automatically.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Owner

@nilsandrey nilsandrey Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot solve this #14 (comment)

Copy link
Copy Markdown
Contributor Author

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR description to include the required <!--changelog-description-start/end--> and <!--changelog-type-start/end--> markers with the Patch checkbox checked.

},
],
},
Expand Down
4 changes: 2 additions & 2 deletions main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,13 +635,13 @@ export default class TextToolsPlugin extends Plugin {
});
this.addCommand({
id: "insert-timestamp-utc",
name: "Insert timestamp (UTC / ISO 8601)",
name: "Insert timestamp (utc / iso 8601)",
editorCallback: (editor) =>
this.insertAtEachSelection(editor, timestampUTC),
});
this.addCommand({
id: "insert-timestamp-unix",
name: "Insert Unix timestamp",
name: "Insert unix timestamp",
editorCallback: (editor) =>
this.insertAtEachSelection(editor, timestampUnix),
});
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/settings-tab.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ export class TextToolsSettingTab extends PluginSettingTab {
// ------------------------------------------------------------------ //
// GUIDs
// ------------------------------------------------------------------ //
new Setting(containerEl).setName("GUIDs").setHeading();
new Setting(containerEl).setName("Guids").setHeading();

new Setting(containerEl)
.setName("Uppercase hex digits")
.setDesc("Insert GUIDs using uppercase hex digits.")
.setDesc("Insert guids using uppercase hex digits.")
.addToggle((t) =>
t
.setValue(this.plugin.settings.insertUppercaseGuids)
Expand Down