Skip to content

Fix sentence case ESLint config for Obsidian review bot compliance#14

Merged
nilsandrey merged 6 commits intomainfrom
copilot/fix-ui-text-sentence-case
Mar 10, 2026
Merged

Fix sentence case ESLint config for Obsidian review bot compliance#14
nilsandrey merged 6 commits intomainfrom
copilot/fix-ui-text-sentence-case

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 9, 2026

Description

Fix sentence case ESLint config: remove redundant "GUIDs" from ignoreWords (handled by CamelCase detection), keeping UTC/ISO/Unix for Obsidian review bot compliance

Related Issues

Type of Change

  • Major – Breaking change (requires a new major version bump)
  • Minor – New feature, backward-compatible (requires a new minor version bump)
  • Patch – Bug fix or internal improvement, backward-compatible (requires a new patch version bump)
Original prompt

This section details on the original issue you should resolve

<issue_title>Issues from obsidian bot</issue_title>
<issue_description>Fix these requirements from: obsidianmd/obsidian-releases#10837 (comment)

Required
[1][2][3][4]
Use sentence case for UI text.</issue_description>

Comments on the Issue (you are @copilot in this section)


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI and others added 2 commits March 9, 2026 20:47
Co-authored-by: nilsandrey <3579285+nilsandrey@users.noreply.github.com>
…om ignoreWords

Co-authored-by: nilsandrey <3579285+nilsandrey@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix UI text to use sentence case Fix sentence case ESLint config for Obsidian review bot compliance Mar 9, 2026
@nilsandrey nilsandrey marked this pull request as ready for review March 9, 2026 22:46
Copilot AI review requested due to automatic review settings March 9, 2026 22:46
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the repository’s ESLint configuration to satisfy eslint-plugin-obsidianmd “sentence case for UI text” checks for Obsidian community review, by treating certain acronyms/proper nouns as allowed words.

Changes:

  • Updates obsidianmd/ui/sentence-case rule config to stop ignoring GUIDs (keeps UTC, ISO, Unix).
  • Updates package-lock.json root version value to 1.0.3 (matching package.json).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
package-lock.json Updates the lockfile’s root version field to 1.0.3.
eslint.config.mjs Adjusts sentence-case rule ignoreWords list and comment to target UTC/ISO/Unix only.

Comment on lines +21 to +22
// These proper nouns and acronyms are not in the plugin's default list
ignoreWords: ["UTC", "ISO", "Unix"],
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR’s description currently doesn’t include the required changelog markers / version-bump checkbox section used by the release workflow ( and with exactly one box checked). Without that, merging to main will cause the Release workflow to fail with “No version bump checkbox selected”. Please update the PR description to match the repository template so releases can be generated automatically.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot solve this #14 (comment)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR description to include the required <!--changelog-description-start/end--> and <!--changelog-type-start/end--> markers with the Patch checkbox checked.

Signed-off-by: Nils <nilsandrey@gmail.com>
Signed-off-by: Nils <nilsandrey@gmail.com>
Signed-off-by: Nils <nilsandrey@gmail.com>
@nilsandrey nilsandrey merged commit 88d7913 into main Mar 10, 2026
@nilsandrey nilsandrey deleted the copilot/fix-ui-text-sentence-case branch March 10, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues from obsidian bot

3 participants