add -Werror to escalate warnings to errors. #1343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blebowski
force-pushed
the
add-werror
branch
2 times, most recently
from
1d180aa to
5e401c5
Compare
Contributor
Author
Owner
|
I don't really think it makes sense to have this as a global option as it now escalates assertion warnings to errors which overlaps with the existing |
Contributor
Author
|
I will convert it to analysis option then. |
Blebowski
force-pushed
the
add-werror
branch
from
5e401c5 to
50b8244
Compare
Contributor
Author
|
Now processed. |
Owner
|
This still has a problem where the option is left enabled after analysis completes. |
nickg
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.