Skip to content

Update to .NET 8#102

Merged
jryckman merged 2 commits intoni:mainfrom
yaqian256:users/yaqian/net8
Dec 1, 2025
Merged

Update to .NET 8#102
jryckman merged 2 commits intoni:mainfrom
yaqian256:users/yaqian/net8

Conversation

@yaqian256
Copy link
Contributor

@yaqian256 yaqian256 commented Nov 18, 2025

Justification

.NET 6 has reached its end of life, and the actions/setup-dotnet@v1 step used in the csharp-styleguide workflow no longer installs it. We need to update to .NET 8 to prevent build errors.

Implementation

  • Updated global.json to use .NET 8 (same as the one in ASW)
  • Removed the NuGet package source in nuget.config to void NU1507 warnings
  • Updated the NIExecutableTargetFramework and NILibraryTargetFramework properties to net8.0.

Testing

builds

@yaqian256 yaqian256 changed the title build with .net 8 Build with .net 8 Nov 18, 2025
@jryckman
Copy link
Collaborator

@nick-beer @pakdev is there anyone else using .NET right now mainly in ASW that can also chime in on this change?

<add key="automatic" value="True" />
</packageRestore>
<packageSources>
<add key="NuGet" value="https://www.nuget.org/api/v2/" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: Removed this to avoid warning NU1507: There are 2 package sources defined in your configuration. When using central package management, please
map your package sources with package source mapping (https://aka.ms/nuget-package-source-mapping) or specify a single package source. The following sources are defined: NuGet, nuget.org

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand this change? I think it would be better to add a <clear /> here.

@yaqian256 yaqian256 changed the title Build with .net 8 Update to .NET 8 Nov 21, 2025
@yaqian256 yaqian256 marked this pull request as ready for review November 21, 2025 00:47
@yaqian256 yaqian256 requested a review from jryckman as a code owner November 21, 2025 00:47
<add key="automatic" value="True" />
</packageRestore>
<packageSources>
<add key="NuGet" value="https://www.nuget.org/api/v2/" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand this change? I think it would be better to add a <clear /> here.

@jryckman jryckman merged commit 48d8aa5 into ni:main Dec 1, 2025
1 check passed
@jryckman
Copy link
Collaborator

jryckman commented Dec 1, 2025

@yaqian256 The change was approved and the PR went in however, please address Nick's comment in nuget.config before I build a new export.

@yaqian256
Copy link
Contributor Author

@yaqian256 The change was approved and the PR went in however, please address Nick's comment in nuget.config before I build a new export.

addressed in #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants