Skip to content

Revert "Update net analyzers to 10.0 (#101)"#103

Merged
jryckman merged 3 commits intomainfrom
copilot/revert-analyzer-config-changes
Dec 3, 2025
Merged

Revert "Update net analyzers to 10.0 (#101)"#103
jryckman merged 3 commits intomainfrom
copilot/revert-analyzer-config-changes

Conversation

Copy link
Contributor

Copilot AI commented Dec 3, 2025

Justification

Reverts commit fb643b0 to isolate the source of the workflow failure at https://github.com/ni/csharp-styleguide/actions/runs/19881347517/job/56980236662.

Implementation

Reverts all changes from the .NET 10 analyzer update:

  • build/NI.CSharp.Analyzers.nuspec: Microsoft.CodeAnalysis.NetAnalyzers 10.0.100 → 9.0.0, copyright year 2025 → 2024
  • nuget.config: Remove <clear /> and explicit nuget.org source
  • src/AnalyzerConfiguration/NI.CSharp.Analyzers.props: AnalysisLevel 10.0 → 9.0
  • src/AnalyzerConfiguration/NI.CSharp.Analyzers.targets: Restore analyzer path analyzers\dotnet\cs\Microsoft.CodeAnalysis.NetAnalyzers.dll

Also adds .objs/ to .gitignore to prevent committing build artifacts.

Testing

Build verified locally. CI will validate the reverted configuration against the failing workflow.

Original prompt

Revert commit fb643b0 in the main branch. The purpose is to temporarily undo recent changes to analyzer versions, analysis levels, and nuget configuration so we can compare build job behavior and isolate the source of the workflow failure documented at https://github.com/ni/csharp-styleguide/actions/runs/19881347517/job/56980236662 (ref: fb643b0).

This pull request was created as a result of the following prompt from Copilot chat.

Revert commit fb643b0 in the main branch. The purpose is to temporarily undo recent changes to analyzer versions, analysis levels, and nuget configuration so we can compare build job behavior and isolate the source of the workflow failure documented at https://github.com/ni/csharp-styleguide/actions/runs/19881347517/job/56980236662 (ref: fb643b0).


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits December 3, 2025 03:53
…on changes

Co-authored-by: jryckman <4111629+jryckman@users.noreply.github.com>
Co-authored-by: jryckman <4111629+jryckman@users.noreply.github.com>
Copilot AI changed the title [WIP] Revert changes to analyzer versions and configurations Revert "Update net analyzers to 10.0 (#101)" Dec 3, 2025
Copilot AI requested a review from jryckman December 3, 2025 03:55
@jryckman jryckman marked this pull request as ready for review December 3, 2025 03:57
@jryckman jryckman requested a review from pakdev as a code owner December 3, 2025 03:57
@jryckman jryckman merged commit 4f52e11 into main Dec 3, 2025
@yaqian256
Copy link
Contributor

@jryckman , the publish failure was not caused by #101. It's caused by #102. There's a new "Release" subfolder in the path to the built nuget package after upgrading to .NET 8.

image

I have a fix for it, see #104

Can you help to revert this revert once that fix goes in?

jryckman added a commit that referenced this pull request Dec 4, 2025
jryckman added a commit that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants