Skip to content

Eye of Ayak fixes #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Richardant wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Eye of Ayak fixes #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/com/attacktimer/AnimationData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ public enum AnimationData
MAGIC_WARPED_SCEPTRE(10501, AttackStyle.MAGIC, false), // https://oldschool.runescape.wiki/w/Warped_sceptre
MAGIC_VOLATILE_NIGHTMARE_STAFF_SPEC(8532, AttackStyle.MAGIC, true), // assume 99 mage's base damage (does not rise when boosted).

MAGIC_EYE_OF_AYAK(12397, AttackStyle.MAGIC, false),
MAGIC_EYE_OF_AYAK_SPEC(12394, AttackStyle.MAGIC, true), // https://github.com/ngraves95/attacktimer/issues/91

// Misc
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/com/attacktimer/AttackTimerMetronomePlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,10 +318,10 @@ private boolean isPlayerAttacking()
}

AnimationData fromId = AnimationData.fromId(animationId);
if (fromId == AnimationData.RANGED_BLOWPIPE || fromId == AnimationData.RANGED_BLAZING_BLOWPIPE)
if (fromId == AnimationData.RANGED_BLOWPIPE || fromId == AnimationData.RANGED_BLAZING_BLOWPIPE || fromId == AnimationData.MAGIC_EYE_OF_AYAK || fromId == AnimationData.MAGIC_EYE_OF_AYAK_SPEC)
Copy link
Contributor

@Lexer747 Lexer747 Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Maybe worth changing to an immutable set as we keep accumulating more of these?

{
// These two animations are the only ones which exceed the duration of their attack cooldown (when
// on rapid), so in this case DO NOT fall back the animation as it is un-reliable.
// These four animations are the only ones which exceed the duration of their attack cooldown
// so in this case DO NOT fall back the animation as it is un-reliable.
return false;
}
// fall back to animations.
Expand Down