Fix: Login Polling Without Cached Responses#128
Merged
Conversation
mpivchev
approved these changes
Mar 10, 2025
Member
|
@mpivchev you can use unauthorizedSession and add the requestCachePolicy = .reloadIgnoringLocalAndRemoteCacheData ;) |
marinofaggiana
requested changes
Mar 10, 2025
Member
marinofaggiana
left a comment
There was a problem hiding this comment.
use unauthorizedSession without caching
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
23d9268 to
73a3649
Compare
Collaborator
Author
|
I updated the branch as requested by @marinofaggiana. |
marinofaggiana
approved these changes
Mar 11, 2025
Collaborator
|
@marinofaggiana @i2h3 no cache option is applied to the whole session, are you sure this won't break other requests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mpivchev figured it out and deserves the credit, I just cleaned up and squashed the branch.
The problem solved is that the iOS app polls some servers infinitely because their negative response is cached client-side even after the user granted app password in the web.