Skip to content

Comments

Fix login poll (again) + Additional bug fix#3351

Merged
marinofaggiana merged 2 commits intodevelopfrom
poll-fix-login-bug-fix
Mar 11, 2025
Merged

Fix login poll (again) + Additional bug fix#3351
marinofaggiana merged 2 commits intodevelopfrom
poll-fix-login-bug-fix

Conversation

@mpivchev
Copy link
Collaborator

  1. Fixes login poll (again)
  2. Fix an issue happening when removing the last account and going back from log in would close both presented login modals and cause the app to go back to home screen with no account.

mpivchev and others added 2 commits March 10, 2025 18:17
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
@mpivchev mpivchev requested review from i2h3 and marinofaggiana March 10, 2025 17:25
@i2h3
Copy link
Contributor

i2h3 commented Mar 11, 2025

I will wait for nextcloud/NextcloudKit#128 to be integrated into develop first.

I know that the fix for the login poll works already.

I am confused about the explicit NextcloudKit 6.0.2 reference here. The polling fix is not even on develop, so actually the development branch reference would have been appropriate (once the fix there is integrated).

@marinofaggiana
Copy link
Member

marinofaggiana commented Mar 11, 2025

I will wait for nextcloud/NextcloudKit#128 to be integrated into develop first.

I know that the fix for the login poll works already.

I am confused about the explicit NextcloudKit 6.0.2 reference here. The polling fix is not even on develop, so actually the development branch reference would have been appropriate (once the fix there is integrated).

don't worry if work I merge in develop with NextcloudKit develop #128 included

@marinofaggiana marinofaggiana merged commit cb10aa9 into develop Mar 11, 2025
5 checks passed
@mpivchev mpivchev deleted the poll-fix-login-bug-fix branch March 12, 2025 10:25
mpivchev added a commit that referenced this pull request Mar 25, 2025
* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* https://github.com/nextcloud/ios/pull/3269/files

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cell fixed

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix section

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* color

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* clean

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* downloadPreview

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* New version

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix login poll timer not cancelling

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* E2EE force refresh after create dir

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* version 6.2.3

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Additional checks for timer

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* menu FIX

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Recommended review NC 31 (#3275)


Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Version 6.2.4

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* fix error

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix appearanceInterfaceStyle

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* build 1

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* added new dictionary

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix timer

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Max request/download/upload concurrent parameter (#3276)


Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* improvements (#3277)


Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* fix and new build

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix high header Recommendations

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Build 3

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Small string changes

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* remove unused strings

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* more

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* remove more strings

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Enabled Greek localization.

Signed-off-by: Iva Horn <iva.horn@icloud.com>

* more strings

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* New headers, menu, buttons in navigation controller, transfers (#3281)


Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* new build

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* set directoryOnTop for account

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* set Title

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* transfersButton Color

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Improvements menu  (#3284)



Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* close button

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* build 5

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* hide button rigth (#3287)


Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* new build

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix Predicate for  PersonalFilesOnly

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* New build

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* #3169 fix ssl client certificate (#3223)

* fix: set NCLogin as NCNetworking certificate delegate

Signed-off-by: Patrick Fischer <mail@patrickfischer.ch>

* fix: ensure UIAlertControllers are presented on main thread

Signed-off-by: Patrick Fischer <mail@patrickfischer.ch>

* fix: cancel authentication challenge instead of default action

Signed-off-by: Patrick Fischer <mail@patrickfischer.ch>

---------

Signed-off-by: Patrick Fischer <mail@patrickfischer.ch>

* Fix string

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* NextcloudKit Swift 6 - new version

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

Fix 2

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

Fix 3

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* fix @objc

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix singleton

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* fix errorDescription

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix Swift6 - warning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Improved code (Swift 6 NextcloudKit)

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Move some class to Sendable

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* coding

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Sendable

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* interceptor

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* detect 401

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Unauthorized (DISABLED)

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* code improvements

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* improved code

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* checkremoreuser

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* improved code

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* improved code

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* improved code

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* cleaning old code

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* metadata-photos-original_date_time

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Code improved

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* databaseSchemaVersion

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Copyright © 2025 Nextcloud. All rights reserved.

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* setupLog

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* update build

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* improved swipe

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Build 2

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* improved code

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* update advanced settings log

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* fix upload foto subfolder (#3302)

* code fixed

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Build 3

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Login v2 internal browser + fix provider log in (#3303)

* Add option to log out of login v2 flow

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Finish

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

---------

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Build 4

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* varie (#3304)

* upload photo offline

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* code improvements

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Auto upload from specific Albums (#3257)

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Fix build

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Fix stateobject redrawing

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Finish

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Apply suggestions from code review

Co-authored-by: Iva Horn <iva.horn@icloud.com>
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* PR reviews

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* PR suggestions

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* PR fixes

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* PR fixes

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Apply suggestions from code review

Co-authored-by: Iva Horn <iva.horn@icloud.com>
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Pr changes

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Fix compile

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Fix compile

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Refactor

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

---------

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Co-authored-by: Iva Horn <iva.horn@icloud.com>

* Fix destination not disabling on auto upload on

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Fix NavigationController (#3305)

* fix

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* build 6

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix delete

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix color album selected

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* remove some old warning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* pushNotification code improved (#3308)

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* push server

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning (push notification)

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix (#3309)

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* nc:metadata-photos-original_date_time

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* build 7

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix completion(newAssets)

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* rollback (#3310)

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* New build

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* change Media to datePhotosOriginal

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Update c 2025

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Media improvements

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Download Limits Including UI Tests

Sharing UI Improvements:
- Improved code organization to improve clarity in the sharing user interface.
- Added NCShareDownloadLimitTableViewControllerDelegate to enable the table view to update the share user interface as the data model owner.
- Added a proper primary key to tableDownloadLimit composed of the account identifier and the share token.
- Added accessibility identifiers to various user interface controls to enable the UI test automation.
- Carved out some types and renamed them to have more descriptive names.

Tests:
- Disabled test parallelization to prevent Xcode from freezing.
- Updated GitHub actions for UI tests.
- Removed xcbeautify from tests action because it will truncate critical error information in GitHub actions.

Review Amendments:
- The remarks of Marino on a previous and meanwhile completely reverted implementation have been taken into account.
- Added namespacing of download limits by account identifiers.
- Removed unnecessary throws.
- Removed redundant property attributes.

Signed-off-by: Iva Horn <iva.horn@icloud.com>

* Second Review Amendments

- Updated README.
- Added convenience script to launch test server.
- Added removal of all accounts on launch when UI_TESTING argument is detected.
- Removed redundant code. This might be a rebase accident.
- Removed obsolete shell scripts for test servers.
- Consolidated XCUIElement extensions into dedicated source code group a single file.

Signed-off-by: Iva Horn <iva.horn@icloud.com>

* Disabled test job in GitHub actions.

Due to the lack of effective tests besides Xcode UI tests which are unfeasible without bare metal runners.

Signed-off-by: Iva Horn <iva.horn@icloud.com>

* Create live photo from two files (image+video) selected (#3317)


Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Build 9

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix #3248: Remove unnecessary _remaining_share_downloads_ (#3319)

Signed-off-by: Iva Horn <iva.horn@icloud.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* fix

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix (#3322)

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* use correct user agent during login (#3325)

Signed-off-by: Serhii Kaliberda <169338670+s-kaliberda@users.noreply.github.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Build 10

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* serious-error-db (#3323)

* fix

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* export tableAccount in json

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* improved code

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning code

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Update iOSClient/Data/NCManageDatabase+Account.swift

Co-authored-by: Iva Horn <iva.horn@icloud.com>
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Update iOSClient/SceneDelegate.swift

Co-authored-by: Iva Horn <iva.horn@icloud.com>
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Update iOSClient/Data/NCManageDatabase.swift

Co-authored-by: Iva Horn <iva.horn@icloud.com>
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Update iOSClient/Data/NCManageDatabase.swift

Co-authored-by: Iva Horn <iva.horn@icloud.com>
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix nk version for test

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Add more logs

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Add more logs

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* new schema version

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Co-authored-by: Iva Horn <iva.horn@icloud.com>
Co-authored-by: Milen Pivchev <milen.pivchev@gmail.com>

* ToS Improvements (#3334)

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix: flip lat/lon from exif to negative when needed

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Build 11 - closed

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* fix order Media

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Version 6.3.1

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning old func not used

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Version 6.4.0

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Improved Auto Upload creation dir/subdir (#3337)

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* improved

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* add selector

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* improved

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* improved

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* add selector

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* improved

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* improvements

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* code improvements (#3338)

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix (#3339)

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* new build

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* WIP (#3336)

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Fix #3248: Pluralized string.

- Introduced Localizable.stringsdict for pluralization.
- Restored _remaining_share_downloads_ string.
- Extended Transifex configuration to include ios-plurals resource.
- Added .tx directory to Xcode project for convenient access to edit.

Signed-off-by: Iva Horn <iva.horn@icloud.com>

* #3248: Removed zero case from English plural location.

Transifex does not allow it.

Signed-off-by: Iva Horn <iva.horn@icloud.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Add back missing strings

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Restore missing strings

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* fix

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* fix crash

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Widget dashboard and file widgets continue to display file lists after logout (#3344)

* fix

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Co-authored-by: Marino Faggiana <marino@marinofaggiana.com>

* Networking Process (#3345)

* fix

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Co-authored-by: Marino Faggiana <marino@marinofaggiana.com>

* Build 4

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Build 5

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Interceptor & Monitor Improved  (#3348)

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* code

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Build 6

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Co-authored-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Process improvements

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning code, change name functions server In Error

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning code

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* change Copyright

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Improvements Server Error (#3349)

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Co-authored-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* fixed timer in background

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Build 8

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix Login

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Build 9

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* More extensive cookie removal for login

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* NextcloudKit 6.0.2

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* new build

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix login poll (again) + Additional bug fix (#3351)

* Fix poll (again), fix bug on going back to login

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* NextcloudKit 6.0.2

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Co-authored-by: Marino Faggiana <marino@marinofaggiana.com>

* NextcloudKit 6.0.3

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Assistant design improvements + V2 API (#3327)

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* refactor

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Change CI code

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* UI tests

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Refactor date

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Refacgtor

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Refactor

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* WIP

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* PR changes

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Update Tests/NextcloudUITests/AssistantUITests.swift

Co-authored-by: Iva Horn <iva.horn@icloud.com>
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* PR fixes

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* PR fixes 2

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* PR fixes 3

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

---------

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Co-authored-by: Iva Horn <iva.horn@icloud.com>

* Revert "Assistant design improvements + V2 API (#3327)"

This reverts commit daa02d3.

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Remove Photo only app active (#3357)

* revert

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix main thread

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Co-authored-by: Marino Faggiana <marino@marinofaggiana.com>

* Assistant design improvements + V2 API (#3327)

* Changed NextcloudKit branch reference from "assistant-v2" to "develop".

Signed-off-by: Iva Horn <iva.horn@icloud.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Remove old code for Nextcloud 17 or lower (#3363)

* Remove code for NC17 and lower

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* String

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Change var

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

---------

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* New assistant button (#3362)

* added assistantButton

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* NCMainNavigationController Improved

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* NCMoreNavigationController

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Media assistant button

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Improved media bar

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Improved media bar

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix priority

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix Assistant icon

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* NCNotification in present

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* improved

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* remove option directory on top

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* show description improvements

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* clean

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Version 6.5.0

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Co-authored-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* clean old code

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix compile

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Fix compile 2

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>

* Search reload  (#3367)

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* new build

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Co-authored-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Improvements code (#3370)

* improvements

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* new build

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Co-authored-by: Marino Faggiana <marino@marinofaggiana.com>

* File provider extension (#3371)

* cod & fix

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Co-authored-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* remove old queue (#3373)

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Co-authored-by: Marino Faggiana <marino@marinofaggiana.com>

* Nc operation delete file or folder (#3374)

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cleaning

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* cod

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* build 3

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Co-authored-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* fix

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* bug fix

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* build 4

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* update share - metadata (#3375)

* step 1

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

* fix

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Co-authored-by: Marino Faggiana <marino@marinofaggiana.com>

* Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* close version

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>

---------

Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Signed-off-by: Iva Horn <iva.horn@icloud.com>
Signed-off-by: Patrick Fischer <mail@patrickfischer.ch>
Signed-off-by: Serhii Kaliberda <169338670+s-kaliberda@users.noreply.github.com>
Co-authored-by: Nextcloud bot <bot@nextcloud.com>
Co-authored-by: Marino Faggiana <marino@marinofaggiana.com>
Co-authored-by: Milen Pivchev <milen.pivchev@gmail.com>
Co-authored-by: Iva Horn <iva.horn@icloud.com>
Co-authored-by: Patrick <zero0cool0@users.noreply.github.com>
Co-authored-by: Serhii Kaliberda <169338670+s-kaliberda@users.noreply.github.com>
Co-authored-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants