feat: Remove period support from formal notation#57
feat: Remove period support from formal notation#57netkeep80 merged 5 commits intonetkeep80:mainfrom
Conversation
Adding .gitkeep for PR creation (created with --gitkeep-file flag). This file will be removed when the task is complete. Issue: netkeep80#56
|
🤖 AI Work Session Started Starting automated work session at 2026-02-13T23:02:48.333Z The PR has been converted to draft mode while work is in progress. This comment marks the beginning of an AI work session. Please wait for the session to finish, and provide your feedback. |
Remove the requirement for periods (.) at the end of formulas. Periods, commas, and newlines can now be used as optional separators between statements, but are not required. Changes: - Parser: Made DOT and COMMA tokens optional separators in parseStatement() - Updated grammar documentation to reflect optional separators - Updated all example .mtl files to remove terminating periods - Updated documentation in formal-notation.md and specification-v0.1.md - Updated tests to reflect new behavior Fixes netkeep80#56 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This reverts commit 2f6abf6.
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
|
Нет, ты не понял, точки вообще не нужны! |
|
🤖 AI Work Session Started Starting automated work session at 2026-02-13T23:13:20.521Z The PR has been converted to draft mode while work is in progress. This comment marks the beginning of an AI work session. Please wait for the session to finish, and provide your feedback. |
Based on feedback from netkeep80, periods should not be supported at all as separators. Only commas and newlines should work as statement separators. Changes: - Updated parser to remove DOT token support in parseStatement() - Updated parseExpr() helper to not append period - Updated EBNF grammar in formal-notation.md and specification-v0.1.md - Updated all test cases to remove periods - All 255 tests pass successfully Addresses feedback in PR netkeep80#57 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Updated all E2E tests to use newlines instead of periods as statement separators, consistent with the new parser behavior. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
✅ PR готов к ревью Все изменения выполнены согласно отзыву:
Периоды ( |
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
Summary
This PR implements the changes requested in #56 to completely remove the requirement for terminating periods (
.) at the end of formulas in the formal notation. Based on feedback, periods are no longer supported as separators - only commas and newlines work.Changes Made
1. Parser Updates
parseStatement()insrc/core/parser.tsto remove period (.) support entirely,) and newlines are now accepted as optional statement separatorsparseExpr()helper to not append a period2. Documentation
Updated formal notation documentation to reflect the new syntax:
docs/mts/formal-notation.md- Updated EBNF grammar to remove period supportdocs/mts/specification-v0.1.md- Updated EBNF grammar to remove period support3. Tests
Test Results
All tests pass successfully:
New Syntax
The formal notation now supports only these separator formats:
Periods are no longer supported as statement separators.
Fixes
Fixes #56
🤖 This PR was created automatically by the AI issue solver