Conversation
Collaborator
Author
|
Screencast from 03-24-2023 08:13:27 PM.webm After the screencast I tried the new frame styling, so camera visual will look better than what's shown in the videos. Leave the tweaking for the future! |
brentyi
reviewed
Mar 25, 2023
| client.add_gui_text("Info", initial_value=f"Client {id}", disabled=True) | ||
|
|
||
| camera = client.get_camera() | ||
| server.set_background_image(render_image_from_camera(camera)) |
Collaborator
There was a problem hiding this comment.
FYI to support multiple clients, you can call client.set_background_image() instead of server.set_background_image(); this will send the message to just one client instead of every client 🙂
Collaborator
Author
There was a problem hiding this comment.
You are right! Just fixed
brentyi
force-pushed
the
main
branch
2 times, most recently
from
8fb03b5 to
d5f8bda
Compare
brentyi
force-pushed
the
main
branch
4 times, most recently
from
5889b1b to
3bf8cac
Compare
|
Oh this is pretty cool! Would it makes sense to have viser supported in nerfacc and put a link here? This would avoid copying that huge chain of code to this repo and make things clean here. |
brentyi
force-pushed
the
main
branch
2 times, most recently
from
401ab8e to
0ed3c73
Compare
brentyi
force-pushed
the
main
branch
5 times, most recently
from
3f8725e to
3e41b46
Compare
brentyi
force-pushed
the
main
branch
2 times, most recently
from
e970ae0 to
fbef89c
Compare
brentyi
force-pushed
the
main
branch
9 times, most recently
from
6ea47b3 to
7a6ab4a
Compare
brentyi
force-pushed
the
main
branch
5 times, most recently
from
dcd992b to
cd3c214
Compare
brentyi
force-pushed
the
main
branch
2 times, most recently
from
be9fb67 to
a704ac6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nerf example working. Currently just streaming with some hard-coded resolution.