0.9.0 cluster state inimbus#519
Closed
jasonjckn wants to merge 4 commits intonathanmarz:masterfrom
jasonjckn:0.9.0-cluster-state-inimbus
Closed
0.9.0 cluster state inimbus#519jasonjckn wants to merge 4 commits intonathanmarz:masterfrom jasonjckn:0.9.0-cluster-state-inimbus
jasonjckn wants to merge 4 commits intonathanmarz:masterfrom
jasonjckn:0.9.0-cluster-state-inimbus
Conversation
This reverts commit 3e29f13. backwards incompatible change reverted, this is moved to 0.9.0-experimental
Collaborator
Author
|
i did this for 0.9.0 branch because it's an api change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull gives me access to cluster-state in INimbus, which is needed for this pull nathanmarz/storm-mesos#5
"IMPORTANT: CuratorFramework instances are fully thread-safe. You should share one CuratorFramework per ZooKeeper cluster in your application." https://github.com/Netflix/curator/wiki/Framework
MesosNimbus needed zk style state, so this pull gets it done. Without making a 2nd curator framework.
I had to use Object for clusterState because ClusterState is a protocol, and therefore not accessible due to compilation ordering where javac goes first. If someone needs ClusterState in java in the future, we can rewrite it without protocols, but there's no sense changing all that code right now when only mesosnimbus needs it, and I wrote it partly in clojure.