MesosNimbus locks in executor URI of newly launched topologies#5
Open
jasonjckn wants to merge 1 commit intonathanmarz:masterfrom
Open
MesosNimbus locks in executor URI of newly launched topologies#5jasonjckn wants to merge 1 commit intonathanmarz:masterfrom
jasonjckn wants to merge 1 commit intonathanmarz:masterfrom
Conversation
This was referenced Mar 25, 2013
Collaborator
Author
|
This pull depends on nathanmarz/storm#520 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if you accidentally had supervisors die, or new assignments, and you changed executor URI path, or overwrote the file that it points to, topologies would run on split versions and you'd never know with certainty which version of storm-mesos-0.0.1 a topology was using.
The new model is immutable for the lifetime of the topology. an executor URI is chosen when a topology is first launch and this setting is permanent until the topology is resubmitted. the URI state is kept in zookeeper. If you change mesos.executor.uri.default, then only newly launched topologies will use this value. I've also added mesos.executor.uri.overrides which overrides the default value, this allows you to gradually release version to users at your discretion, and you can slowly roll out your updates.
In this new model, whenever you do a new release of storm-mesos you place it at a new location, with a new URI. If you do an in-place update, then the behaviour is as it was before this patch.