Support for multipolygons in zonal_statistics#428
Merged
emilyanndavis merged 3 commits intonatcap:mainfrom Apr 22, 2025
Merged
Conversation
emlys
commented
Apr 8, 2025
| layer.SyncToDisk() | ||
| layer = None | ||
| vector = None | ||
| _geometry_to_vector([geom], vector_path, projection_epsg=4326) |
Member
Author
There was a problem hiding this comment.
Updating a few unrelated tests to use _geometry_to_vector - better to avoid duplicating all the layer creation code, and it sets the geometry type correctly, which is now required.
emlys
changed the title
zonal_statistics
This was referenced Apr 8, 2025
emilyanndavis
approved these changes
Apr 22, 2025
Member
emilyanndavis
left a comment
emilyanndavis
left a comment
There was a problem hiding this comment.
Thanks, @emlys! Looking forward to seeing fewer warnings in the InVEST logs. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #322
zonal_statistics, use the appropriate geometry type according to the input type (Polygon or MultiPolygon) to prevent the warnings seen sometimes in invest.A PR in invest (natcap/invest#1882) goes along with this, but the order of merging doesn't matter.