HRA update to go along with pygeoprocessing #322#1882
Merged
emlys merged 5 commits intonatcap:mainfrom May 19, 2025
Merged
Conversation
2 tasks
Member
|
Hmm something seems to be a little funky with GHA. I'll let it cook a little longer and see if the actions complete. Otherwise, this change is so simple I'm happy to just merge. |
Member
Author
|
I fixed a whitespace issue that was causing the HISTORY.rst check to fail. The ReadTheDocs failure seems unrelated, so I'm going to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1881
The changes made in natcap/pygeoprocessing#428 caused an HRA test to fail, because HRA's geometry simplification function was always setting the vector geometry type to
Unknown.pygeoprocessing.zonal_statisticswill now require a type ofPolygonorMultiPolygon, so this raised an error.To resolve it, I am updating HRA to copy the geometry type over from the input vector. This may still be
Unknownfor habitat or stressor layers, but should always bePolygonorMultiPolygonfor the AOI (whichzonal_statisticsis run on).Checklist