sync: create missing parent hierarchy for remote beta roots#554
Open
Doow501 wants to merge 1 commit intomutagen-io:masterfrom
Open
sync: create missing parent hierarchy for remote beta roots#554Doow501 wants to merge 1 commit intomutagen-io:masterfrom
Doow501 wants to merge 1 commit intomutagen-io:masterfrom
Conversation
2e35b47 to
d37cd31
Compare
d37cd31 to
488bd7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do and why is it needed?
This pull request allows writable remote beta endpoints to create the missing
parent directory hierarchy for a synchronization root when the root itself does
not yet exist.
Today, synchronization can proceed if the root is missing but its parent
directory already exists. However, if the parent hierarchy is missing,
transition fails when attempting to walk to the synchronization root parent.
This change keeps the behavior narrow:
This is needed to make first-time remote synchronization setup work more
smoothly when the target directory hierarchy has not yet been created on the
remote side.
Which issue(s) does this pull request address (if any)?
Closes #553
Any other notes for the review process?
This PR also adds tests covering: