Skip to content

Conversation

@shadylua
Copy link
Contributor

@shadylua shadylua commented Sep 7, 2025

This PR refactors the reload script to run server-side only, removing the client-side implementation.

Shady1 and others added 2 commits September 7, 2025 17:35
This PR refactors the reload script to run server-side only, removing the client-side implementation.
Copy link
Contributor

@omar-o22 omar-o22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, but I think the spamTimer you added might actually hurt the player experience and in my opinion it’s not a good solution if what you intended is to prevent reload while already reloading using isPedReloadingWeapon would be a better approach

Copy link
Contributor

@jlillis jlillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would introduce new problems than improvements:

1 - By moving all the logic server side, we lose the ability to block reload during certain tasks (getPedSimplestTask is client-only).
2 - By moving the bindKey call server side, players lose the ability to change the keybind via the MTA settings menu.

I think the current approach with both client and server logic works best.

@Dutchman101
Copy link
Member

We will have to reject this PR for reasons such as what jlillis explained.
Even with event triggers, performance and delays to check states will be subpar and not suitable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants