Skip to content

ARM: dts: qcom: msm8974-samsung-lt03lte: enable gpio keys #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vrajashkr wants to merge 1 commit into
base: qcom-msm8974-6.15.y
Choose a base branch
from
+37 −0
Open

ARM: dts: qcom: msm8974-samsung-lt03lte: enable gpio keys #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions arch/arm/boot/dts/qcom/qcom-msm8974-samsung-lt03lte.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#include "qcom-msm8974.dtsi"
#include "pm8841.dtsi"
#include "pm8941.dtsi"
#include <dt-bindings/input/input.h>
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>

/ {
Expand All @@ -14,6 +15,35 @@
mmc1 = &sdhc_3; /* SDC3 SD card slot */
};

gpio-keys {
compatible = "gpio-keys";

pinctrl-0 = <&gpio_keys_active_pin>;
pinctrl-names = "default";

key-home {
wakeup-source;
label = "Home Key";
gpios = <&pm8941_gpios 3 GPIO_ACTIVE_LOW>;
linux,code = <KEY_HOMEPAGE>;
debounce-interval = <15>;
Copy link
Copy Markdown
Member

@z3ntu z3ntu Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boolean properties (wakeup-source) behind others

Copy link
Copy Markdown
Contributor Author

@vrajashkr vrajashkr Mar 30, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've made a change to place that before the other props.

Does this apply to other props for pinctrl too? I see bias settings usually show up in between other props (usually in between function and power source if specified).

};

key-volume-down {
label = "Volume Down";
gpios = <&pm8941_gpios 2 GPIO_ACTIVE_LOW>;
linux,code = <KEY_VOLUMEDOWN>;
debounce-interval = <15>;
};

key-volume-up {
label = "Volume Up";
gpios = <&pm8941_gpios 5 GPIO_ACTIVE_LOW>;
linux,code = <KEY_VOLUMEUP>;
debounce-interval = <15>;
};
};

tsp_sw3_2v8: regulator-tsp-sw3-2v8 {
compatible = "regulator-fixed";
regulator-name = "tsp_sw3_2v8";
Expand Down Expand Up @@ -380,6 +410,13 @@
};

&pm8941_gpios {
gpio_keys_active_pin: gpio-keys-active-state {
pins = "gpio2", "gpio3", "gpio5";
function = "normal";
bias-pull-up;
power-source = <PM8941_GPIO_S3>;
};

fuelgauge_pin: fuelgauge-int-state {
pins = "gpio26";
function = "normal";
Expand Down