Skip to content

ARM: dts: qcom: msm8974-samsung-lt03lte: enable gpio keys#31

Open
vrajashkr wants to merge 1 commit intomsm8974-mainline:qcom-msm8974-6.15.yfrom
vrajashkr:lt03lte-gpio-keys
Open

ARM: dts: qcom: msm8974-samsung-lt03lte: enable gpio keys#31
vrajashkr wants to merge 1 commit intomsm8974-mainline:qcom-msm8974-6.15.yfrom
vrajashkr:lt03lte-gpio-keys

Conversation

@vrajashkr
Copy link
Copy Markdown
Contributor

@vrajashkr vrajashkr commented Mar 30, 2026

Enables the following GPIO input keys for msm8974-samsung-lt03lte:

  • Volume Up
  • Volume Down
  • Physical Home Key

@vrajashkr
Copy link
Copy Markdown
Contributor Author

vrajashkr commented Mar 30, 2026

Tested with evtest:

$ sudo evtest /dev/input/event0
Input driver version is 1.0.1
Input device ID: bus 0x19 vendor 0x1 product 0x1 version 0x100
Input device name: "gpio-keys"
Supported events:
  Event type 0 (EV_SYN)
  Event type 1 (EV_KEY)
    Event code 114 (KEY_VOLUMEDOWN)
    Event code 115 (KEY_VOLUMEUP)
    Event code 172 (KEY_HOMEPAGE)
Properties:
Testing ... (interrupt to exit)
Event: time 1774447964.889232, type 1 (EV_KEY), code 114 (KEY_VOLUMEDOWN), value 1
Event: time 1774447964.889232, -------------- SYN_REPORT ------------
Event: time 1774447965.068474, type 1 (EV_KEY), code 114 (KEY_VOLUMEDOWN), value 0
Event: time 1774447965.068474, -------------- SYN_REPORT ------------
Event: time 1774447973.792548, type 1 (EV_KEY), code 115 (KEY_VOLUMEUP), value 1
Event: time 1774447973.792548, -------------- SYN_REPORT ------------
Event: time 1774447973.957551, type 1 (EV_KEY), code 115 (KEY_VOLUMEUP), value 0
Event: time 1774447973.957551, -------------- SYN_REPORT ------------
Event: time 1774447980.594856, type 1 (EV_KEY), code 172 (KEY_HOMEPAGE), value 1
Event: time 1774447980.594856, -------------- SYN_REPORT ------------
Event: time 1774447980.683284, type 1 (EV_KEY), code 172 (KEY_HOMEPAGE), value 0
Event: time 1774447980.683284, -------------- SYN_REPORT ------------

z3ntu
z3ntu reviewed Mar 30, 2026
View reviewed changes
arch/arm/boot/dts/qcom/qcom-msm8974-samsung-lt03lte.dts
gpios = <&pm8941_gpios 3 GPIO_ACTIVE_LOW>;
linux,code = <KEY_HOMEPAGE>;
wakeup-source;
debounce-interval = <15>;
Copy link
Copy Markdown
Member

@z3ntu z3ntu Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boolean properties (wakeup-source) behind others

Copy link
Copy Markdown
Contributor Author

@vrajashkr vrajashkr Mar 30, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've made a change to place that before the other props.

Does this apply to other props for pinctrl too? I see bias settings usually show up in between other props (usually in between function and power source if specified).

@z3ntu
Copy link
Copy Markdown
Member

z3ntu commented Mar 30, 2026

nice, happy to see your contributions!

@z3ntu z3ntu added the enhancement New feature or request label Mar 30, 2026
@vrajashkr
ARM: dts: qcom: msm8974-samsung-lt03lte: enable gpio keys
b9c2d08 
Enables the following GPIO input keys for msm8974-samsung-lt03lte:
- Volume Up
- Volume Down
- Physical Home Key

Signed-off-by: Vishwas Rajashekar <dev@vrajashkr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@z3ntu z3ntu z3ntu left review comments

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vrajashkr @z3ntu