Skip to content

Update DTS/Panel for HTC One M8 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XirXes wants to merge 3 commits into
base: qcom-msm8974-6.15.y
Choose a base branch
from
Open

Update DTS/Panel for HTC One M8 #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
664db67
ARM: dts: qcom: Add GPU and Panel to HTC M8 DTB
XirXes Feb 24, 2026
1a5ed70
drm/panel: Add M8 Sharp Novatek 35595 DSI panel driver
XirXes Feb 24, 2026
1e82086
ARM: dts: qcom: htc-m8: Drop monitored battery from smbb
XirXes Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 62 additions & 0 deletions arch/arm/boot/dts/qcom/qcom-msm8974pro-htc-m8.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
#include "pm8941.dtsi"
#include <dt-bindings/input/input.h>
#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
Copy link
Copy Markdown
Member

@z3ntu z3ntu Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort the headers alphabetically, irq.h goes between input.h and leds/common.h

#include <dt-bindings/power/qcom-rpmpd.h>

/ {
model = "HTC One (M8)";
Expand Down Expand Up @@ -65,6 +68,50 @@
};
};

&gpu {
status = "okay";
};

&mdss {
status = "okay";
};

&mdss_dsi0 {
status = "okay";

vdd-supply = <&pm8941_l22>;
vddio-supply = <&pm8941_l12>;
vdda-supply = <&pm8941_l2>;
panel@0 {
Copy link
Copy Markdown
Member

@z3ntu z3ntu Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the sorting/formatting like this

	vdd-supply = <&pm8941_l22>;
	vddio-supply = <&pm8941_l12>;
	vdda-supply = <&pm8941_l2>;

	status = "okay";

	panel@0 {

Status property goes last. Keep an empty line between properties and subnodes

compatible = "mdss,m8-sharp-novatek-35595";
reg = <0>;
power-supply = <&pm8941_l12>;
Copy link
Copy Markdown
Member

@z3ntu z3ntu Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you not have any better name than power-supply? Do you have schematics? If so, the proper names should be visible there


pinctrl-names = "default";
pinctrl-0 = <&panel_te_pin>, <&panel_rst_pin>;
backlight-gpios = <&pm8941_gpios 4 GPIO_ACTIVE_HIGH>;
Copy link
Copy Markdown
Member

@z3ntu z3ntu Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put backlight-gpios up next to power-supply.

for pinctrl, first pinctrl-0, then pinctrl-names


port {
panel_in: endpoint {
remote-endpoint = <&mdss_dsi0_out>;
};
};
};
};

&mdss_dsi0_out {
data-lanes = <0 1 2 3>;
remote-endpoint = <&panel_in>;
};

&mdss_dsi0_phy {
status = "okay";
Copy link
Copy Markdown
Member

@z3ntu z3ntu Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status goes last


vdd-supply = <&pm8941_l22>;
vddio-supply = <&pm8941_l12>;
vdda-supply = <&pm8941_l2>;
};

&blsp1_i2c2 {
clock-frequency = <384000>;

Expand Down Expand Up @@ -398,6 +445,21 @@
bias-pull-down;
};
};

panel_te_pin: panel-te-state {
pins = "gpio12";
function = "mdp_vsync";
drive-strength = <2>;
bias-disable;
};

panel_rst_pin: panel-rst-state {
pins = "gpio13";
function = "gpio";
bias-disable;
power-source = <PM8941_GPIO_S3>;
qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>;
};
};

&usb {
Expand Down
10 changes: 10 additions & 0 deletions drivers/gpu/drm/panel/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,16 @@ config DRM_PANEL_LG_SW43408
pixel. It provides a MIPI DSI interface to the host and has a
built-in LED backlight.

config DRM_PANEL_M8_SHARP_NOVATEK_35595
tristate "M8 HTC Sharp Novatek 35595 DSI panel"
depends on OF
depends on DRM_MIPI_DSI
depends on BACKLIGHT_CLASS_DEVICE
select VIDEOMODE_HELPERS
help
DRM panel driver for the HTC M8 Sharp Novatek 35595 command mode panel. This panel receives
video data via DSI.

config DRM_PANEL_MAGNACHIP_D53E6EA8966
tristate "Magnachip D53E6EA8966 DSI panel"
depends on OF && SPI
Expand Down
1 change: 1 addition & 0 deletions drivers/gpu/drm/panel/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ obj-$(CONFIG_DRM_PANEL_LINCOLNTECH_LCD197) += panel-lincolntech-lcd197.o
obj-$(CONFIG_DRM_PANEL_LG_LB035Q02) += panel-lg-lb035q02.o
obj-$(CONFIG_DRM_PANEL_LG_LG4573) += panel-lg-lg4573.o
obj-$(CONFIG_DRM_PANEL_LG_SW43408) += panel-lg-sw43408.o
obj-$(CONFIG_DRM_PANEL_M8_SHARP_NOVATEK_35595) += panel-m8-sharp-novatek-35595.o
obj-$(CONFIG_DRM_PANEL_MAGNACHIP_D53E6EA8966) += panel-magnachip-d53e6ea8966.o
obj-$(CONFIG_DRM_PANEL_NEC_NL8048HL11) += panel-nec-nl8048hl11.o
obj-$(CONFIG_DRM_PANEL_NEWVISION_NV3051D) += panel-newvision-nv3051d.o
Expand Down
Loading