Update DTS/Panel for HTC One M8#28
Update DTS/Panel for HTC One M8#28XirXes wants to merge 3 commits intomsm8974-mainline:qcom-msm8974-6.15.yfrom
Conversation
Enable Panel and Adreno GPU on HTC One M8 device tree.
Sharp 1080p command mode DSI panel with Novatek 35595 controller and DCS backlight. Found in the HTC One M8.
Accidentally included this monitored battery, the rest of the battery code wasn't included in the change due to lack of smbb-bms driver
|
Please add your downstream dtb that you used to generate the panel driver from to https://github.com/msm8974-mainline/linux-panel-drivers I'd also highly encourage you to clean up the panel driver and submit it for inclusion upstream, then also the panel can be enabled upstream. Not strictly required though, we have enough panel drivers lying around in msm8974-mainline/linux |
| #include <dt-bindings/input/input.h> | ||
| #include <dt-bindings/leds/common.h> | ||
| #include <dt-bindings/pinctrl/qcom,pmic-gpio.h> | ||
| #include <dt-bindings/interrupt-controller/irq.h> |
There was a problem hiding this comment.
Please sort the headers alphabetically, irq.h goes between input.h and leds/common.h
| vdd-supply = <&pm8941_l22>; | ||
| vddio-supply = <&pm8941_l12>; | ||
| vdda-supply = <&pm8941_l2>; | ||
| panel@0 { |
There was a problem hiding this comment.
Please make the sorting/formatting like this
vdd-supply = <&pm8941_l22>;
vddio-supply = <&pm8941_l12>;
vdda-supply = <&pm8941_l2>;
status = "okay";
panel@0 {Status property goes last. Keep an empty line between properties and subnodes
| panel@0 { | ||
| compatible = "mdss,m8-sharp-novatek-35595"; | ||
| reg = <0>; | ||
| power-supply = <&pm8941_l12>; |
There was a problem hiding this comment.
do you not have any better name than power-supply? Do you have schematics? If so, the proper names should be visible there
| }; | ||
|
|
||
| &mdss_dsi0_phy { | ||
| status = "okay"; |
|
|
||
| pinctrl-names = "default"; | ||
| pinctrl-0 = <&panel_te_pin>, <&panel_rst_pin>; | ||
| backlight-gpios = <&pm8941_gpios 4 GPIO_ACTIVE_HIGH>; |
There was a problem hiding this comment.
put backlight-gpios up next to power-supply.
for pinctrl, first pinctrl-0, then pinctrl-names
2 participants
These changes enable the display on the HTC One M8, and enable the GPU. Tested and working with Phosh UI with Wayland.