docs: add missing FeatureHolder methods to FML spec#789
Open
jaredlockhart wants to merge 1 commit intomainfrom
Open
docs: add missing FeatureHolder methods to FML spec#789jaredlockhart wants to merge 1 commit intomainfrom
jaredlockhart wants to merge 1 commit intomainfrom
Conversation
Because * Several FeatureHolder methods in the source are undocumented in the FML spec: recordExperimentExposure, recordMalformedConfiguration, toJSONObject, and the testing helpers * Co-enrollment exposure recording pattern was only in the co-enrollment doc, not the main FML reference This commit * Adds recordExperimentExposure(slug) for co-enrolling features with Swift and Kotlin examples * Adds recordMalformedConfiguration(partId) for reporting invalid experiment configurations as Glean telemetry * Adds toJSONObject() for getting raw JSON representation * Adds testing helpers section: withCachedValue, withInitializer, withSdk, isUnderTest with examples and cross-link to Android integration guide Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jaredlockhart
requested review from
freshstrangemusic,
mikewilli,
relud and
yashikakhurana
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds documentation for several FeatureHolder methods that exist in the source but were missing from the FML specification.
recordExperimentExposure(slug)— exposure recording for co-enrolling features (Swift + Kotlin examples)recordMalformedConfiguration(partId)— report invalid experiment configs as Glean telemetrytoJSONObject()— get raw JSON representation of feature configurationwithCachedValue(),withInitializer(),withSdk(),isUnderTest()with usage examples and cross-link to Android integration guideFixes #788
🤖 Generated with Claude Code