Checks and unit tests for empty jira payloads#330
Merged
isabelrios merged 5 commits intomasterfrom Apr 8, 2026
Merged
Conversation
Collaborator
Author
|
To consolidate and reduce duplication.. I am also removing the references to JIRA_ env variables since we will be using the ATLASSIAN_ ones which have the same value. |
AaronMT
approved these changes
Apr 8, 2026
Collaborator
AaronMT
left a comment
AaronMT
left a comment
There was a problem hiding this comment.
This is great, thanks Isabel. One comment.
| if 'database' not in sys.modules: | ||
| sys.modules['database'] = MagicMock() | ||
|
|
||
| ATLASSIAN_BASE_URL = f"https://{os.environ['ATLASSIAN_HOST']}/rest/api/3/" |
Collaborator
There was a problem hiding this comment.
This runs at import time, so if ATLASSIAN_HOST isn't set, the entire test module will fail to import with a KeyError, maybe rapping it in os.environ.get('ATLASSIAN_HOST', 'localhost') or moving it into setUp
Collaborator
Author
There was a problem hiding this comment.
If the host is not set.. it makes sense this all fails...it is always the same and set in secrets
isabelrios
force-pushed
the
irios-fix-jira-worklogs
branch
from
07ff5c5 to
f906a09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent silent failures caused by expired Jira API tokens, which return empty payloads with a
200 status, making builds appear successful while wiping the database, this PR adds:
or revoked
before touching the database if 0 issues or 0 worklogs are returned