Checks and unit tests for empty jira payloads (#330)

isabelrios · web-flow · commit 6bd3bd63698d · 2026-04-08T19:39:27.000+02:00
* Checks and unit tests for empty jira payloads

* fix lint

* fix unit tests

* consolidate JIRA references with ATLASSIAN
diff --git a/.github/workflows/confluence-daily-dte.yaml b/.github/workflows/confluence-daily-dte.yaml
@@ -44,10 +44,6 @@ jobs:
             echo "TESTRAIL_USERNAME=${{ secrets.TESTRAIL_USERNAME }}" >> $GITHUB_ENV
             echo "TESTRAIL_PASSWORD=${{ secrets.TESTRAIL_PASSWORD }}" >> $GITHUB_ENV
             echo "GITHUB_TOKEN=${{ secrets.GITHUB_TOKEN }}" >> $GITHUB_ENV
-            echo "JIRA_HOST=${{ secrets.JIRA_HOST }}" >> $GITHUB_ENV
-            echo "JIRA_USER=${{ secrets.JIRA_USER }}" >> $GITHUB_ENV
-            echo "JIRA_PASSWORD=${{ secrets.JIRA_PASSWORD }}" >> $GITHUB_ENV
-
             echo "BUGZILLA_API_KEY=${{ secrets.BUGZILLA_API_KEY }}" >> $GITHUB_ENV
 
             echo "ATLASSIAN_API_TOKEN=${{ secrets.ATLASSIAN_API_TOKEN }}" >> $GITHUB_ENV
diff --git a/.github/workflows/confluence-daily.yaml b/.github/workflows/confluence-daily.yaml
@@ -38,9 +38,6 @@ jobs:
             echo "TESTRAIL_USERNAME=${{ secrets.TESTRAIL_USERNAME }}" >> $GITHUB_ENV
             echo "TESTRAIL_PASSWORD=${{ secrets.TESTRAIL_PASSWORD }}" >> $GITHUB_ENV
             echo "GITHUB_TOKEN=${{ secrets.GITHUB_TOKEN }}" >> $GITHUB_ENV
-            echo "JIRA_HOST=${{ secrets.JIRA_HOST }}" >> $GITHUB_ENV
-            echo "JIRA_USER=${{ secrets.JIRA_USER }}" >> $GITHUB_ENV
-            echo "JIRA_PASSWORD=${{ secrets.JIRA_PASSWORD }}" >> $GITHUB_ENV
 
             echo "BUGZILLA_API_KEY=${{ secrets.BUGZILLA_API_KEY }}" >> $GITHUB_ENV
 
diff --git a/.github/workflows/preflight-push.yaml b/.github/workflows/preflight-push.yaml
@@ -26,9 +26,6 @@ env:
   ATLASSIAN_API_TOKEN: ${{ secrets.ATLASSIAN_API_TOKEN }}
   ATLASSIAN_HOST: ${{ secrets.ATLASSIAN_HOST }}
   ATLASSIAN_USERNAME: ${{ secrets.ATLASSIAN_USERNAME }}
-  JIRA_HOST: ${{ secrets.JIRA_HOST }}
-  JIRA_USER: ${{ secrets.JIRA_USER }}
-  JIRA_PASSWORD: ${{ secrets.JIRA_PASSWORD }}
   GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
   BUGZILLA_API_KEY: ${{ secrets.BUGZILLA_API_KEY }}
   BITRISE_HOST: ${{ secrets.BITRISE_HOST }}
diff --git a/.github/workflows/production-daily-desktop.yaml b/.github/workflows/production-daily-desktop.yaml
@@ -57,9 +57,6 @@ jobs:
             echo "TESTRAIL_USERNAME=${{ secrets.TESTRAIL_USERNAME }}" >> $GITHUB_ENV
             echo "TESTRAIL_PASSWORD=${{ secrets.TESTRAIL_PASSWORD }}" >> $GITHUB_ENV
             echo "GITHUB_TOKEN=${{ secrets.GITHUB_TOKEN }}" >> $GITHUB_ENV
-            echo "JIRA_HOST=${{ secrets.JIRA_HOST }}" >> $GITHUB_ENV
-            echo "JIRA_USER=${{ secrets.JIRA_USER }}" >> $GITHUB_ENV
-            echo "JIRA_PASSWORD=${{ secrets.JIRA_PASSWORD }}" >> $GITHUB_ENV
             echo "BUGZILLA_API_KEY=${{ secrets.BUGZILLA_API_KEY }}" >> $GITHUB_ENV
             echo "ATLASSIAN_API_TOKEN=${{ secrets.ATLASSIAN_API_TOKEN }}" >> $GITHUB_ENV
             echo "ATLASSIAN_HOST=${{ secrets.ATLASSIAN_HOST }}" >> $GITHUB_ENV
diff --git a/.github/workflows/production-daily.yml b/.github/workflows/production-daily.yml
@@ -22,9 +22,6 @@ env:
   ATLASSIAN_API_TOKEN: ${{ secrets.ATLASSIAN_API_TOKEN }}
   ATLASSIAN_HOST: ${{ secrets.ATLASSIAN_HOST }}
   ATLASSIAN_USERNAME: ${{ secrets.ATLASSIAN_USERNAME }}
-  JIRA_HOST: ${{ secrets.JIRA_HOST }}
-  JIRA_USER: ${{ secrets.JIRA_USER }}
-  JIRA_PASSWORD: ${{ secrets.JIRA_PASSWORD }}
   GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
   BUGZILLA_API_KEY: ${{ secrets.BUGZILLA_API_KEY }}
   BITRISE_HOST: ${{ secrets.BITRISE_HOST }}
diff --git a/.github/workflows/production-weekly-desktop.yaml b/.github/workflows/production-weekly-desktop.yaml
@@ -57,9 +57,6 @@ jobs:
             echo "ATLASSIAN_HOST=${{ secrets.ATLASSIAN_HOST }}" >> $GITHUB_ENV
             echo "ATLASSIAN_USERNAME=${{ secrets.ATLASSIAN_USERNAME }}" >> $GITHUB_ENV
             echo "BUGZILLA_API_KEY=${{ secrets.BUGZILLA_API_KEY }}" >> $GITHUB_ENV
-            echo "JIRA_HOST=${{ secrets.JIRA_HOST }}" >> $GITHUB_ENV
-            echo "JIRA_USER=${{ secrets.JIRA_USER }}" >> $GITHUB_ENV
-            echo "JIRA_PASSWORD=${{ secrets.JIRA_PASSWORD }}" >> $GITHUB_ENV
       - run: python ./__main__.py ${{ matrix.args }}
         continue-on-error: true
 
diff --git a/.github/workflows/production-weekly-firefox-ios-deepdive.yaml b/.github/workflows/production-weekly-firefox-ios-deepdive.yaml
@@ -23,9 +23,6 @@ env:
   ATLASSIAN_API_TOKEN: ${{ secrets.ATLASSIAN_API_TOKEN }}
   ATLASSIAN_HOST: ${{ secrets.ATLASSIAN_HOST }}
   ATLASSIAN_USERNAME: ${{ secrets.ATLASSIAN_USERNAME }}
-  JIRA_HOST: ${{ secrets.JIRA_HOST }}
-  JIRA_USER: ${{ secrets.JIRA_USER }}
-  JIRA_PASSWORD: ${{ secrets.JIRA_PASSWORD }}
   GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
   BUGZILLA_API_KEY: ${{ secrets.BUGZILLA_API_KEY }}
   BITRISE_HOST: ${{ secrets.BITRISE_HOST }}
diff --git a/.github/workflows/production-weekly.yml b/.github/workflows/production-weekly.yml
@@ -44,9 +44,6 @@ jobs:
             echo "ATLASSIAN_API_TOKEN=${{ secrets.ATLASSIAN_API_TOKEN }}" >> $GITHUB_ENV
             echo "ATLASSIAN_HOST=${{ secrets.ATLASSIAN_HOST }}" >> $GITHUB_ENV
             echo "ATLASSIAN_USERNAME=${{ secrets.ATLASSIAN_USERNAME }}" >> $GITHUB_ENV
-            echo "JIRA_HOST=${{ secrets.JIRA_HOST }}" >> $GITHUB_ENV
-            echo "JIRA_USER=${{ secrets.JIRA_USER }}" >> $GITHUB_ENV
-            echo "JIRA_PASSWORD=${{ secrets.JIRA_PASSWORD }}" >> $GITHUB_ENV
 
       #- name: Update DB - test runs 
       #  run: python ./__main__.py --report-type test-run-counts --project ALL --num-days 7
diff --git a/.github/workflows/staging-daily-desktop.yml b/.github/workflows/staging-daily-desktop.yml
@@ -55,9 +55,6 @@ jobs:
             echo "TESTRAIL_USERNAME=${{ secrets.TESTRAIL_USERNAME }}" >> $GITHUB_ENV
             echo "TESTRAIL_PASSWORD=${{ secrets.TESTRAIL_PASSWORD }}" >> $GITHUB_ENV
             echo "GITHUB_TOKEN=${{ secrets.GITHUB_TOKEN }}" >> $GITHUB_ENV
-            echo "JIRA_HOST=${{ secrets.JIRA_HOST }}" >> $GITHUB_ENV
-            echo "JIRA_USER=${{ secrets.JIRA_USER }}" >> $GITHUB_ENV
-            echo "JIRA_PASSWORD=${{ secrets.JIRA_PASSWORD }}" >> $GITHUB_ENV
             echo "BUGZILLA_API_KEY=${{ secrets.BUGZILLA_API_KEY }}" >> $GITHUB_ENV
             echo "ATLASSIAN_API_TOKEN=${{ secrets.ATLASSIAN_API_TOKEN }}" >> $GITHUB_ENV
             echo "ATLASSIAN_HOST=${{ secrets.ATLASSIAN_HOST }}" >> $GITHUB_ENV
diff --git a/.github/workflows/staging-daily.yml b/.github/workflows/staging-daily.yml
@@ -23,9 +23,6 @@ env:
   ATLASSIAN_API_TOKEN: ${{ secrets.ATLASSIAN_API_TOKEN }}
   ATLASSIAN_HOST: ${{ secrets.ATLASSIAN_HOST }}
   ATLASSIAN_USERNAME: ${{ secrets.ATLASSIAN_USERNAME }}
-  JIRA_HOST: ${{ secrets.JIRA_HOST }}
-  JIRA_USER: ${{ secrets.JIRA_USER }}
-  JIRA_PASSWORD: ${{ secrets.JIRA_PASSWORD }}
   GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
   BUGZILLA_API_KEY: ${{ secrets.BUGZILLA_API_KEY }}
   BITRISE_HOST: ${{ secrets.BITRISE_HOST }}
diff --git a/.github/workflows/staging-weekly-desktop.yml b/.github/workflows/staging-weekly-desktop.yml
@@ -57,9 +57,6 @@ jobs:
             echo "ATLASSIAN_HOST=${{ secrets.ATLASSIAN_HOST }}" >> $GITHUB_ENV
             echo "ATLASSIAN_USERNAME=${{ secrets.ATLASSIAN_USERNAME }}" >> $GITHUB_ENV
             echo "BUGZILLA_API_KEY=${{ secrets.BUGZILLA_API_KEY }}" >> $GITHUB_ENV
-            echo "JIRA_HOST=${{ secrets.JIRA_HOST }}" >> $GITHUB_ENV
-            echo "JIRA_USER=${{ secrets.JIRA_USER }}" >> $GITHUB_ENV
-            echo "JIRA_PASSWORD=${{ secrets.JIRA_PASSWORD }}" >> $GITHUB_ENV
       - run: python ./__main__.py ${{ matrix.args }}
         continue-on-error: true
 
diff --git a/.github/workflows/staging-weekly.yml b/.github/workflows/staging-weekly.yml
@@ -23,9 +23,6 @@ env:
   ATLASSIAN_API_TOKEN: ${{ secrets.ATLASSIAN_API_TOKEN }}
   ATLASSIAN_HOST: ${{ secrets.ATLASSIAN_HOST }}
   ATLASSIAN_USERNAME: ${{ secrets.ATLASSIAN_USERNAME }}
-  JIRA_HOST: ${{ secrets.JIRA_HOST }}
-  JIRA_USER: ${{ secrets.JIRA_USER }}
-  JIRA_PASSWORD: ${{ secrets.JIRA_PASSWORD }}
   GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
   BUGZILLA_API_KEY: ${{ secrets.BUGZILLA_API_KEY }}
   BITRISE_HOST: ${{ secrets.BITRISE_HOST }}
diff --git a/.github/workflows/unit-tests-daily.yml b/.github/workflows/unit-tests-daily.yml
@@ -0,0 +1,47 @@
+name: Unit Tests - Daily
+
+# Daily @9am UTC + manual trigger
+on:
+  schedule:
+    - cron: "0 9 * * *"
+  workflow_dispatch:
+
+env:
+  ATLASSIAN_USERNAME: ${{ secrets.ATLASSIAN_USERNAME }}
+  ATLASSIAN_API_TOKEN: ${{ secrets.ATLASSIAN_API_TOKEN }}
+
+jobs:
+  unit-tests:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out source repository
+        uses: actions/checkout@v6
+
+      - name: Set up Python environment
+        uses: actions/setup-python@v6
+        with:
+          python-version: "3.11"
+
+      - name: Install dependencies
+        run: pip install -r requirements.txt
+
+      - name: Run unit tests
+        run: python -m unittest discover -s tests -v
+
+      - name: Set job log URL
+        if: always()
+        run: echo "JOB_LOG_URL=https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}" >> $GITHUB_ENV
+
+      - name: Send workflow status to Slack
+        if: always()
+        uses: slackapi/slack-github-action@v3.0.1
+        env:
+          WORKFLOW_NAME: ${{ github.workflow }}
+          BRANCH: ${{ github.head_ref || github.ref_name }}
+          JOB_STATUS: ${{ job.status == 'success' && ':white_check_mark:' || ':x:' }}
+          JOB_STATUS_COLOR: ${{ job.status == 'success' && '#36a64f' || '#FF0000' }}
+        with:
+          webhook: ${{ secrets.SLACK_WEBHOOK_URL_MOBILE_ALERTS_TOOLING }}
+          webhook-type: webhook-trigger
+          payload-templated: true
+          payload-file-path: "./config/payload-slack-content.json"
diff --git a/api/jira/client.py b/api/jira/client.py
@@ -18,7 +18,6 @@
     FILTER_ID_ALL_REQUEST_ISSUE_TYPE,
     FILTER_ID_QA_NEEDED_iOS,
     FIREFOX_RELEASE_TRAIN,
-    HOST_JIRA,
     MAX_RESULT,
     QATT_BOARD,
     QATT_PARENT_TICKETS_IN_BOARD,
@@ -33,11 +32,10 @@ class Jira:
 
     def __init__(self):
         try:
-            # _url_host = os.environ['JIRA_HOST']
-            _url_host = f"https://{HOST_JIRA}/rest/api/3"
+            _url_host = f"https://{os.environ['ATLASSIAN_HOST']}/rest/api/3"
             self.client = JiraAPIClient(_url_host)
-            self.client.user = os.environ['JIRA_USER']
-            self.client.password = os.environ['JIRA_PASSWORD']
+            self.client.user = os.environ['ATLASSIAN_USERNAME']
+            self.client.password = os.environ['ATLASSIAN_API_TOKEN']
         except KeyError:
             print("ERROR: Missing jira env var")
             sys.exit(1)
diff --git a/api/jira/report_qa_requests.py b/api/jira/report_qa_requests.py
@@ -55,8 +55,10 @@ def jira_qa_requests():
     df = prepare_jira_df(payload)
 
     if df.empty:
-        logger.warning("Jira filtersreturned empty payload; no DB delete/insert.")
-        return
+        raise ValueError(
+            "jira_qa_requests returned empty payload — "
+            "check Jira credentials or filter. Database was not modified."
+        )
 
     jira_delete(ReportJiraQARequests)
 
@@ -92,8 +94,10 @@ def jira_qa_requests_workload():
     df = prepare_jira_df(payload)
 
     if df.empty:
-        logger.warning("Empty payload; skipping DB delete/insert.")
-        return
+        raise ValueError(
+            "jira_qa_requests_workload returned empty payload — "
+            "check Jira credentials or filter. Database was not modified."
+        )
 
     jira_delete(ReportJIraQARequestsNewIssueType)
 
diff --git a/api/jira/report_qa_requests_desktop.py b/api/jira/report_qa_requests_desktop.py
@@ -79,8 +79,10 @@ def jira_qa_requests_desktop():
     df = prepare_jira_df(payload)
 
     if df.empty:
-        logger.warning("Jira filtersreturned empty payload; no DB delete/insert.")
-        return
+        raise ValueError(
+            "jira_qa_requests_desktop returned empty payload — "
+            "check Jira credentials or filter. Database was not modified."
+        )
 
     jira_delete(ReportJiraQARequestsDesktop)
 
diff --git a/api/jira/report_worklogs.py b/api/jira/report_worklogs.py
@@ -42,6 +42,12 @@ def jira_worklogs():
     worklog_data = []
     issues = jira.filter_sv_parent_in_board()
 
+    if not issues:
+        raise ValueError(
+            "No issues returned from QATT board — "
+            "check Jira credentials or filter. Database was not modified."
+        )
+
     for issue in issues:
         parent_key = (issue.get("fields", {}).get("parent") or {}).get("key", issue.get("key"))  # noqa
         parent_name = issue.get("fields", {}).get("summary", "Unknown")
@@ -139,6 +145,12 @@ def jira_worklogs():
     # FIX: Replace NaN values with None for MySQL compatibility
     df = df.astype(object).where(df.notna(), None)
 
+    if df.empty:
+        raise ValueError(
+            "Issues were fetched but no worklog data found — "
+            "Database was not modified."
+        )
+
     jira_delete(ReportJiraSoftvisionWorklogs)
     report_jira_worklogs_insert(df)
 
diff --git a/constants.py b/constants.py
@@ -65,9 +65,6 @@
     "sentry-rates",
 ]
 
-# Jira Host
-HOST_JIRA = "mozilla-hub.atlassian.net"
-
 # JQL query options
 SEARCH = "search/jql"
 ISSUES = "issues"
diff --git a/tests/test_jira_api_client.py b/tests/test_jira_api_client.py
