-
Notifications
You must be signed in to change notification settings - Fork 0
Improved state management #1447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emake method to determine files/job scheduled
3 tasks
…ndency graph, unify downstream nodes for both data structures
…wnstream nodes, allow future_state to receive files, add new endpoint to retrieve state
1a9b3a4 to
c4d780a
Compare
…hen used in the run endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW FEATURES:
save-configsave-configget_configCODE
statefind_buildable_targets- gets them from the config. This keeps targets consistent from calls toconfigandruncompletedfiles/jobs instead of searching through the dagOTHER NOTES
-We always generate a new config even if the params + available files are the same. We let snakemake determine this.
API CHANGES:
Modification to
save-configNow returns
where the state object looks like:
Modification to
create-workspaceNew param type:
dag: obj.dagreturns an adjacency list that represents the job dag (in json)New param:
file_dag: which is the file dag - also in jsonNew endpoint
get-confignew endpoint
get-config-api/v2/:project_name/workspace/:workspace_id/config/:config_id