Skip to content

polyphemus - highlight when a commit param is false #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dtm2451 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

polyphemus - highlight when a commit param is false #1397

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b3f86f
polyphemus - icon highlighting when a commit param is false
dtm2451 May 29, 2025
8d26532
Merge branch 'master' into db/polyphemus-dry-run-icon
dtm2451 Jun 30, 2025
d50bfc2
polyphemus - edit 'dry run mode' tooltip wording
dtm2451 Jun 30, 2025
02d3e78
Merge branch 'master' into db/polyphemus-dry-run-icon
dtm2451 Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions polyphemus/lib/client/jsx/workflow/run-pane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import InputAdornment from '@material-ui/core/InputAdornment';
import {makeStyles} from '@material-ui/core/styles';
import WorkflowPane, {WorkflowPaneHeader} from './workflow-pane';
import Autocomplete from '@material-ui/lab/Autocomplete';
import ReportProblemOutlinedIcon from '@material-ui/icons/ReportProblemOutlined';

import {
RUN_NEVER,
Expand Down Expand Up @@ -274,6 +275,11 @@ const RunPane = ({
);
}, [savePayload, params, param_opts]);

const dryRun = useMemo(() => {
const nextParams = {...params, ...newParams}
return 'commit' in nextParams && !nextParams['commit']
}, [param_opts, params, newParams])

return (
<WorkflowPane mode='run' selected={selected}>
<WorkflowPaneHeader title='Run'>
Expand Down Expand Up @@ -323,6 +329,20 @@ const RunPane = ({
</span>
</Tooltip>
</Grid>
{ dryRun &&
<Grid item>
<Tooltip title="Parsed updates will not be committed to the database">
<Grid item container alignItems='center' spacing={0}>
<Grid item>
<ReportProblemOutlinedIcon/>
</Grid>
<Grid item>
<Typography>Dry Run Mode</Typography>
</Grid>
</Grid>
</Tooltip>
</Grid>
}
{(error || message) && (
<Grid item className={error ? classes.error : classes.completed}>
<Typography>{error || message}</Typography>
Expand Down