polyphemus - highlight when a commit param is false #1397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graft
reviewed
May 29, 2025
| </Grid> | ||
| { dryRun && | ||
| <Grid item> | ||
| <Tooltip title="Parsed updates will not be 'commit'ed to the database"> |
Contributor
There was a problem hiding this comment.
why 'comit'ed instead of committed?
Contributor
Author
There was a problem hiding this comment.
the parameter is named 'commit' so it felt like a good hint to that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be very confusing to run a polyphemus loader, and see a log that looks like it would capture some change you know would come, but then to not see your expected update in Timur.
This can happen due to running the loader with the 'commit' param set to false. This does get injected into the log, but the one-liner is easy enough to miss.
PR adds an icon and text highlighting that the loader is set to "Dry Run Mode", with tooltip explaining further and calling out 'commit'. (Tooltip: "Parsed updates will not be 'commit'ed to the database")
