Skip to content

Fix/56 final code review_explicit import#57

Merged
leonhaufe merged 6 commits intomainfrom
fix/56-final-code-review
Jan 28, 2025
Merged

Fix/56 final code review_explicit import#57
leonhaufe merged 6 commits intomainfrom
fix/56-final-code-review

Conversation

@yunseopark-kaist
Copy link
Collaborator

Changed every using/import expressions to explicitly specify the functions or type definitions needed..

@yunseopark-kaist yunseopark-kaist linked an issue Jan 27, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
src/ParallelPlots.jl 99.02% <100.00%> (ø)

-removed DrWatson from root project.toml
-raise load error at watson_example.jl as previous version
Copy link
Collaborator

@leonhaufe leonhaufe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really god, good job!

@leonhaufe leonhaufe merged commit a14b944 into main Jan 28, 2025
3 checks passed
@yunseopark-kaist yunseopark-kaist deleted the fix/56-final-code-review branch January 29, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Final code review

3 participants