Skip to content

Fix/56 final code review_explicit import #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leonhaufe merged 6 commits into from
Jan 28, 2025
Merged

Fix/56 final code review_explicit import #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
18d998f
fix/explicit import for some packages
yunseopark-kaist Jan 27, 2025
083db65
fix/all imports are explicit now
yunseopark-kaist Jan 27, 2025
d978bdb
fix/removed unnecessary dependency
yunseopark-kaist Jan 27, 2025
63661e8
temporal: error in watson_example
yunseopark-kaist Jan 27, 2025
49510be
fix/added 'repr' to the assertion fail message to avoit type error
yunseopark-kaist Jan 27, 2025
c9a837a
fix/reverted some unnecessary changes
yunseopark-kaist Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ Interpolations = "a98d9a8b-a2ab-59e6-89dd-64a1c18fca59"
[compat]
CairoMakie = "0.12.18"
DataFrames = "1.7.0"
julia = "1.10"
Interpolations = "0.15.1"
julia = "1.10"
6 changes: 3 additions & 3 deletions src/ParallelPlots.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module ParallelPlots

using CairoMakie
using DataFrames
using Interpolations
#using Interpolations


function normalize_DF(data::DataFrame)
Expand Down Expand Up @@ -153,15 +153,15 @@ function Makie.plot!(pp::ParallelPlot{<:Tuple{<:DataFrame}})
# therefore we need to check if user selected features
if !isnothing(pp.feature_selection[])
# use the last seleted feature as color_col
@assert pp.feature_selection[][end] in names(data) "Feature Selection ("*pp.feature_selection[][end]*") is not available in DataFrame ("*string(names(data))*")"
@assert pp.feature_selection[][end] in names(data) "Feature Selection ("*repr(pp.feature_selection[][end])*") is not available in DataFrame ("*string(names(data))*")"
pp.feature_selection[][end]
else
names(data)[end] # no columns selected, use the last one
end

else
# check if name is available
@assert pp.color_feature[] in names(data) "Color Feature ("*pp.color_feature[]*") is not available in DataFrame ("*string(names(data))*")"
@assert pp.color_feature[] in names(data) "Color Feature ("*repr(pp.color_feature[])*") is not available in DataFrame ("*string(names(data))*")"
pp.color_feature[]
end
color_values = data[:,color_col] # Get all values for selected feature
Expand Down
Loading
Loading