Skip to content

Bundle Bootstrap JS file and remove dependency XStatic-Bootstrap #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RogerHaase merged 2 commits into from
Feb 9, 2026
Merged

Bundle Bootstrap JS file and remove dependency XStatic-Bootstrap #2149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f09c76
Bundle bootstrap.min.js form Bootstrap 5.3.8
roland-ruedenauer Feb 8, 2026
a54c9c5
Remove dependency XStatic-Bootstrap
roland-ruedenauer Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ dependencies = [
"sqlalchemy >= 2.0", # used by sqla store
"typing_extensions >= 4.12.2",
"XStatic >= 0.0.2, < 2.0.0", # support for static file pypi packages
"XStatic-Bootstrap >=5.3.8.0, <= 5.3.8.0",
"XStatic-Font-Awesome >= 6.2.1.0, <= 6.2.1.1",
"XStatic-CKEditor >= 3.6.1.2, <= 3.6.4.0",
"XStatic-autosize <= 1.17.2.1",
Expand Down
1 change: 0 additions & 1 deletion src/moin/config/wikiconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,6 @@ class Config(DefaultConfig):
mod_names = [
"jquery",
"jquery_file_upload",
"bootstrap",
"font_awesome",
"ckeditor",
"autosize",
Expand Down
7 changes: 7 additions & 0 deletions src/moin/static/js/bootstrap.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/moin/themes/basic/templates/layout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,6 @@

{% block body_scripts %}
{{ super() }}
<script src="{{ url_for('serve.files', name='bootstrap', filename='js/bootstrap.min.js') }}"></script>
<script src="{{ url_for('static', filename='js/bootstrap.min.js') }}"></script>
<script src="{{ url_for('static', filename='js/basic.js') }}"></script>
{% endblock %}