Skip to content

Bundle Bootstrap JS file and remove dependency XStatic-Bootstrap#2149

Merged
RogerHaase merged 2 commits intomoinwiki:masterfrom
roland-ruedenauer:bundle-bootstrap-js
Feb 9, 2026
Merged

Bundle Bootstrap JS file and remove dependency XStatic-Bootstrap#2149
RogerHaase merged 2 commits intomoinwiki:masterfrom
roland-ruedenauer:bundle-bootstrap-js

Conversation

@roland-ruedenauer
Copy link
Contributor

@roland-ruedenauer roland-ruedenauer commented Feb 8, 2026

This should fix the CI build issues seen on 2 current PRs.

This error occurs for all the Python environments the GitHub CI runs pytest on:

Collecting XStatic-Bootstrap<=5.3.8.0,>=5.3.8.0 (from moin==0.1.dev1+ga9c5bd4b0.d20260208)
  Downloading xstatic_bootstrap-5.3.8.0.tar.gz (1.5 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.5/1.5 MB 57.0 MB/s  0:00:00
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'error'
  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [26 lines of output]
      Traceback (most recent call last):
        File "/opt/hostedtoolcache/Python/3.14.2/x64/lib/python3.14/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
          main()
          ~~~~^^
        File "/opt/hostedtoolcache/Python/3.14.2/x64/lib/python3.14/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 373, in main
          json_out["return_val"] = hook(**hook_input["kwargs"])
                                   ~~~~^^^^^^^^^^^^^^^^^^^^^^^^
        File "/opt/hostedtoolcache/Python/3.14.2/x64/lib/python3.14/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 143, in get_requires_for_build_wheel
          return hook(config_settings)
        File "/tmp/pip-build-env-mbll5hiz/overlay/lib/python3.14/site-packages/setuptools/build_meta.py", line 333, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=[])
                 ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-mbll5hiz/overlay/lib/python3.14/site-packages/setuptools/build_meta.py", line 301, in _get_build_requires
          self.run_setup()
          ~~~~~~~~~~~~~~^^
        File "/tmp/pip-build-env-mbll5hiz/overlay/lib/python3.14/site-packages/setuptools/build_meta.py", line 520, in run_setup
          super().run_setup(setup_script=setup_script)
          ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-mbll5hiz/overlay/lib/python3.14/site-packages/setuptools/build_meta.py", line 317, in run_setup
          exec(code, locals())
          ~~~~^^^^^^^^^^^^^^^^
        File "<string>", line 1, in <module>
        File "/tmp/pip-install-9qxcau34/xstatic-bootstrap_1fc3e38b9f054cc3ab9e445f1e9f895d/xstatic/__init__.py", line 1, in <module>
          __import__('pkg_resources').declare_namespace(__name__)
          ~~~~~~~~~~^^^^^^^^^^^^^^^^^
      ModuleNotFoundError: No module named 'pkg_resources'
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed to build 'XStatic-Bootstrap' when getting requirements to build wheel
Error: Process completed with exit code 1.

The moin CI build is broken because of XStatic-Bootstrap

```
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [23 lines of output]
      Traceback (most recent call last):
        File "/opt/hostedtoolcache/Python/3.12.12/x64/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
          main()
        File "/opt/hostedtoolcache/Python/3.12.12/x64/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 373, in main
          json_out["return_val"] = hook(**hook_input["kwargs"])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/opt/hostedtoolcache/Python/3.12.12/x64/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 143, in get_requires_for_build_wheel
          return hook(config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-0l9fl0o2/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 333, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=[])
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-0l9fl0o2/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 301, in _get_build_requires
          self.run_setup()
        File "/tmp/pip-build-env-0l9fl0o2/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 520, in run_setup
          super().run_setup(setup_script=setup_script)
        File "/tmp/pip-build-env-0l9fl0o2/overlay/lib/python3.12/site-packages/setuptools/build_meta.py", line 317, in run_setup
          exec(code, locals())
        File "<string>", line 1, in <module>
        File "/tmp/pip-install-zk6bc9xe/xstatic-bootstrap_699c08c73d1345258f1ddcd2da75589f/xstatic/__init__.py", line 1, in <module>
          __import__('pkg_resources').declare_namespace(__name__)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
      ModuleNotFoundError: No module named 'pkg_resources'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed to build 'XStatic-Bootstrap' when getting requirements to build wheel
Error: Process completed with exit code 1.
```
@roland-ruedenauer roland-ruedenauer marked this pull request as ready for review February 8, 2026 20:35
@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Feb 9, 2026

The root cause:

pypa/setuptools#5007 (comment)

So setuptools<82 instead of bundling all the 3rd party stuff.

@roland-ruedenauer
Copy link
Contributor Author

The main reason:

After years of developing suitable replacements in importlib.resources and importlib.metadata, Setuptools is now prepared to retire the pkg_resources module.

@RogerHaase RogerHaase merged commit 548b568 into moinwiki:master Feb 9, 2026
10 checks passed
@roland-ruedenauer roland-ruedenauer deleted the bundle-bootstrap-js branch February 9, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants