Skip to content

Add zero check for a value #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yakov-g wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add zero check for a value #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/Python/RestModelServing/restful_sklearn_serving/sklearn_restful_serving.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,8 @@ def predict(self, url_params, form_params):
.format(pred_probs, pred_index, prediction, prediction_confidence))

# Total confidence
self._total_confidence_metric.increase(prediction_confidence)
if self._total_confidence_metric:
Copy link
Copy Markdown

@zohar-mizrahi zohar-mizrahi Jun 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following a discussion with Yakov, we've agreed that trying to run the restful components by using the __name__ == __main__ should not be supported anymore. It leads to potential weird and complicated bugs. Currently we support a standalone mode via mlpiper command line tool.

self._total_confidence_metric.increase(prediction_confidence)

if self._num_predictable_classes:
# Prediction confidence per class
Expand Down