Open
Conversation
When running sklearn restful serving as standalone component _total_confidence_metric is None object, as it is not configured with the configure() which is called from deputy.
zohar-mizrahi
approved these changes
Jun 18, 2019
|
|
||
| # Total confidence | ||
| self._total_confidence_metric.increase(prediction_confidence) | ||
| if self._total_confidence_metric: |
There was a problem hiding this comment.
Following a discussion with Yakov, we've agreed that trying to run the restful components by using the __name__ == __main__ should not be supported anymore. It leads to potential weird and complicated bugs. Currently we support a standalone mode via mlpiper command line tool.
zohar-mizrahi
approved these changes
Jun 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running sklearn restful serving as standalone component
_total_confidence_metric is None object, as it is not configured with
the configure() which is called from deputy.