Skip to content

✨ feat rename leaderboard permission keys and update edits #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkmccarty merged 1 commit into from
Apr 5, 2026
Merged

✨ feat rename leaderboard permission keys and update edits #2329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/boost/coop_status_permission.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func HandleCoopStatusPermissionButton(s *discordgo.Session, i *discordgo.Interac
Content: &content,
Components: &emptyComponents,
}
_, err = s.FollowupMessageEdit(i.Interaction, i.Message.ID, &edit)
_, err = s.InteractionResponseEdit(i.Interaction, &edit)
if err != nil {
log.Println("Error updating coop status permission dialog:", err)
}
Expand Down
6 changes: 3 additions & 3 deletions src/boost/leaderboard_permission.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ import (

const (
// LeaderboardPermissionKey is the key used to store the timestamp of when the user allowed leaderboard API permissions
LeaderboardPermissionKey = "allow_leaderboard_api"
LeaderboardPermissionKey = "allow_leaderboard_apix"
// LeaderboardPermissionSpanKey holds the selected permission duration ("24h" or "forever")
LeaderboardPermissionSpanKey = "allow_leaderboard_api_span"
LeaderboardPermissionSpanKey = "allow_leaderboard_apix_span"
Comment on lines 13 to +17
Copy link

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permission misc-setting keys changed from "allow_leaderboard_api*" to "allow_leaderboard_apix*". This looks like an accidental typo ("apix") and will cause all existing stored permissions to be ignored, forcing every user to re-consent. If the intent is a rename, consider keeping the original key name or implementing a fallback/migration that reads the old key(s) when the new ones are missing; also update the adjacent comment so it matches the actual key used.

Copilot uses AI. Check for mistakes.
// LeaderboardPermission24h is the duration for 24 hours permission
LeaderboardPermission24h = 24 * time.Hour
)
Expand Down Expand Up @@ -106,7 +106,7 @@ func HandleLeaderboardPermissionButton(s *discordgo.Session, i *discordgo.Intera
Content: &content,
Components: &emptyComponents,
}
_, err = s.FollowupMessageEdit(i.Interaction, i.Message.ID, &edit)
_, err = s.InteractionResponseEdit(i.Interaction, &edit)
if err != nil {
log.Println("Error updating leaderboard permission dialog:", err)
}
Expand Down
Loading