✨ feat rename leaderboard permission keys and update edits#2329
✨ feat rename leaderboard permission keys and update edits#2329
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the permission-dialog handling for leaderboard and coop-status flows, and changes the persisted misc-setting keys used for leaderboard permission tracking.
Changes:
- Renamed the leaderboard permission misc-setting keys (
LeaderboardPermissionKey,LeaderboardPermissionSpanKey). - Switched permission dialog “close/update” behavior from
FollowupMessageEdittoInteractionResponseEditfor both leaderboard and coop-status permission dialogs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/boost/leaderboard_permission.go | Renames stored permission keys and updates dialog message editing to use InteractionResponseEdit. |
| src/boost/coop_status_permission.go | Updates dialog message editing to use InteractionResponseEdit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const ( | ||
| // LeaderboardPermissionKey is the key used to store the timestamp of when the user allowed leaderboard API permissions | ||
| LeaderboardPermissionKey = "allow_leaderboard_api" | ||
| LeaderboardPermissionKey = "allow_leaderboard_apix" | ||
| // LeaderboardPermissionSpanKey holds the selected permission duration ("24h" or "forever") | ||
| LeaderboardPermissionSpanKey = "allow_leaderboard_api_span" | ||
| LeaderboardPermissionSpanKey = "allow_leaderboard_apix_span" |
There was a problem hiding this comment.
The permission misc-setting keys changed from "allow_leaderboard_api*" to "allow_leaderboard_apix*". This looks like an accidental typo ("apix") and will cause all existing stored permissions to be ignored, forcing every user to re-consent. If the intent is a rename, consider keeping the original key name or implementing a fallback/migration that reads the old key(s) when the new ones are missing; also update the adjacent comment so it matches the actual key used.
No description provided.