Skip to content

irmin-fs: Eio backend#2316

Merged
clecat merged 3 commits intomirage:eiofrom
art-w:eio-fs-conf
Aug 27, 2025
Merged

irmin-fs: Eio backend#2316
clecat merged 3 commits intomirage:eiofrom
art-w:eio-fs-conf

Conversation

@art-w
Copy link
Contributor

@art-w art-w commented May 14, 2024

Follow-up on #2149 to fix the Eio backend of irmin-fs.unix:

  • The effects to access the eio capabilities had to go, as they break as soon as we spawn fibers which will escape the handler scope
  • Rather, the eio capabilities are passed through the irmin Conf as this is the least invasive solution that we found... The main issue is that irmin-cli expects to be able to deserialize the conf values from the command-line / config file: the underhanded solution to this is to parametrize the conf Spec by the required eio capabilities. Cons: we technically loose spec uniqueness per backend, but this didn't seem to be used anyway other than for sanity checking irmin?

WDYT of renaming irmin-fs.unix to irmin-fs.eio?

Copy link
Contributor

@clecat clecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work, LGTM

@cuihtlauac
Copy link

LGTM too

@clecat clecat merged commit f2abe70 into mirage:eio Aug 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants