Conversation
cuihtlauac
reviewed
Jul 23, 2025
cuihtlauac
suggested changes
Aug 27, 2025
cuihtlauac
approved these changes
Aug 27, 2025
clecat
approved these changes
Aug 27, 2025
Contributor
clecat
left a comment
There was a problem hiding this comment.
Thank you for your work, LGTM
|
LGTM too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #2149 to fix the Eio backend of
irmin-fs.unix:Confas this is the least invasive solution that we found... The main issue is thatirmin-cliexpects to be able to deserialize the conf values from the command-line / config file: the underhanded solution to this is to parametrize the confSpecby the required eio capabilities. Cons: we technically loose spec uniqueness per backend, but this didn't seem to be used anyway other than for sanity checking irmin?WDYT of renaming
irmin-fs.unixtoirmin-fs.eio?