Conversation
|
Thanks a lot for all the hard work! I've rebased your PR on top of #2316 and changed a few things to pass the Eio capabilities through the Irmin Conf/Spec in the same way as for the |
355ad32 to
d055f97
Compare
52b9bb9 to
2da3d56
Compare
2da3d56 to
c15bbc3
Compare
92dc813 to
afcab00
Compare
afcab00 to
adf1003
Compare
1709ebb to
89ce7e4
Compare
cuihtlauac
left a comment
There was a problem hiding this comment.
That's a partial review, I haven't looked at bench, examples and test. I don't get the details, but it looks fairly good. Some cosmetic remarks along.
b575149 to
efccae8
Compare
88134c2 to
56824d1
Compare
|
I think I'm in favor of merging this if no one else objects and following up with some additional PRs around synchronization (like #2281) and testing |
|
Sounds good to me. |
|
Merged ! Thank you, everyone, for your hard work on this (and thanks to @clecat for pushing it through). Great job! |
Make the Io module of
Irmin-packcompatible witheio.This work involves using the Eio related functions for all io operations.
Most of the work relies on propagating the eio switch that will be necessary in order to open the files.