Skip to content

Move Irmin_pack.Io to eio#2280

Merged
samoht merged 17 commits intomirage:eiofrom
clecat:move-io-to-eio
Nov 5, 2025
Merged

Move Irmin_pack.Io to eio#2280
samoht merged 17 commits intomirage:eiofrom
clecat:move-io-to-eio

Conversation

@clecat
Copy link
Contributor

@clecat clecat commented Jan 30, 2024

Make the Io module of Irmin-pack compatible with eio.
This work involves using the Eio related functions for all io operations.
Most of the work relies on propagating the eio switch that will be necessary in order to open the files.

@art-w art-w force-pushed the move-io-to-eio branch from b58d26e to 9046cf5 Compare May 15, 2024 16:01
@art-w art-w changed the base branch from eio-mirage to eio May 15, 2024 16:02
@art-w
Copy link
Contributor

art-w commented May 15, 2024

Thanks a lot for all the hard work! I've rebased your PR on top of #2316 and changed a few things to pass the Eio capabilities through the Irmin Conf/Spec in the same way as for the irmin-fs eio backend. I'm leaving this PR as a draft for now as I saw a couple of (* TODO *) left in the diff and things we could still simplify :)

@clecat clecat force-pushed the move-io-to-eio branch 6 times, most recently from 52b9bb9 to 2da3d56 Compare September 1, 2025 12:51
@clecat clecat marked this pull request as ready for review September 1, 2025 12:56
@clecat clecat changed the title [WIP] Move Irmin_pack.Io to eio Move Irmin_pack.Io to eio Sep 4, 2025
@clecat clecat force-pushed the move-io-to-eio branch 2 times, most recently from 92dc813 to afcab00 Compare September 9, 2025 15:34
Copy link

@cuihtlauac cuihtlauac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a partial review, I haven't looked at bench, examples and test. I don't get the details, but it looks fairly good. Some cosmetic remarks along.

@samoht
Copy link
Member

samoht commented Nov 4, 2025

What's the status of this PR. @lyrm and @zshipko are you happy to merge?

@zshipko
Copy link
Contributor

zshipko commented Nov 5, 2025

I think I'm in favor of merging this if no one else objects and following up with some additional PRs around synchronization (like #2281) and testing

@lyrm
Copy link

lyrm commented Nov 5, 2025

Sounds good to me.

@samoht samoht merged commit a76dfaa into mirage:eio Nov 5, 2025
3 checks passed
@samoht
Copy link
Member

samoht commented Nov 5, 2025

Merged !

Thank you, everyone, for your hard work on this (and thanks to @clecat for pushing it through). Great job!

@clecat clecat mentioned this pull request Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants