Update webviewComm.ts iframe to allow clipboard api#739
Open
CarterWilde wants to merge 1 commit intomicrosoft:mainfrom
Open
Update webviewComm.ts iframe to allow clipboard api#739CarterWilde wants to merge 1 commit intomicrosoft:mainfrom
CarterWilde wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When using live preview, it's not possible to copy and paste the preview content. This was due to the iframe created by webviewComm not including the appropriate allow attribute permissions for the Clipboard API. This change updates the iframe to include clipboard-read and clipboard-write permissions, allowing users to copy and paste from the preview.
|
@andreamah or someone plz merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using live preview, it's not possible to copy and paste the preview content.
This was due to the
iframecreated bywebviewCommnot including the appropriateallowattribute permissions for the Clipboard API.This change updates the
iframeto includeclipboard-readandclipboard-writepermissions, allowing users to copy and paste from the preview.