Skip to content

[gklib, metis] Add support for x64-mingw-dynamic #49865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BillyONeal merged 2 commits into from
Feb 10, 2026
Merged

[gklib, metis] Add support for x64-mingw-dynamic #49865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efd569a
[metis] USE_GKREGEX is passed by gklib's CMake
bansan85 Feb 7, 2026
bd45af6
[gklib] Add regex for mingw
bansan85 Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ports/gklib/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ vcpkg_from_github(
SHA512 54ba87f2c47e025ada0fe6fe608d9d144df5cd13e97e71892dbba4d50cd96409add309937a540cdf8bd2632cbfbc0e22e080a32d114ba6037008c8676aa8d88d
PATCHES
build-fixes.patch
regex.patch
)

string(COMPARE EQUAL "${VCPKG_LIBRARY_LINKAGE}" "dynamic" SHARED)
Expand Down
13 changes: 13 additions & 0 deletions ports/gklib/regex.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
--- 71aac9f2f8-6ab87cd67d.clean/CMakeLists.txt.old 2026-02-05 23:01:42.685830600 +0100
+++ 71aac9f2f8-6ab87cd67d.clean/CMakeLists.txt 2026-02-05 23:02:00.820495600 +0100
@@ -109,6 +109,10 @@ if(NOT HAVE_PCREPOSIX_H)
check_include_file(regex.h HAVE_REGEX_H)
if(NOT HAVE_REGEX_H)
set(USE_GKREGEX ON)
+ else()
+ if(MINGW)
+ target_link_libraries(${PROJECT_NAME} PUBLIC regex)
Copy link
Member

@BillyONeal BillyONeal Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overloading the project name and a target name does not seem like a good idea to me but it is consistent with what upstream does ( https://github.com/KarypisLab/GKlib/blob/6e7951358fd896e2abed7887196b6871aac9f2f8/CMakeLists.txt#L50C1-L50C31 ); no change requested

+ endif()
endif()
endif()

1 change: 1 addition & 0 deletions ports/gklib/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "gklib",
"version-date": "2025-07-06",
"port-version": 1,
"description": "General helper libraries for KarypisLab.",
"homepage": "https://github.com/KarypisLab/GKlib/",
"license": "Apache-2.0",
Expand Down
14 changes: 14 additions & 0 deletions ports/metis/build-fixes-gkregex.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
--- 3b0b581ab2-3f513bfb0c.clean/conf/gkbuild.cmake.old 2026-02-07 18:50:18.944623000 +0100
+++ 3b0b581ab2-3f513bfb0c.clean/conf/gkbuild.cmake 2026-02-07 18:51:19.086997000 +0100
@@ -16,9 +16,9 @@ option(GKRAND "enable GKRAND support" OF

# Add compiler flags.
if(MSVC)
- set(GK_COPTIONS "-DWIN32 -DMSC -D_CRT_SECURE_NO_DEPRECATE -DUSE_GKREGEX")
+ set(GK_COPTIONS "-DWIN32 -DMSC -D_CRT_SECURE_NO_DEPRECATE")
Copy link
Member

@BillyONeal BillyONeal Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please submit this as a PR to https://github.com/KarypisLab/METIS/blob/master/conf/gkbuild.cmake

Copy link
Contributor Author

@bansan85 bansan85 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KarypisLab/METIS#117

elseif(MINGW)
- set(GK_COPTS "-DUSE_GKREGEX")
+# set(GK_COPTS "-DUSE_GKREGEX")
else()
set(GK_COPTIONS "-DLINUX -D_FILE_OFFSET_BITS=64")
endif(MSVC)
1 change: 1 addition & 0 deletions ports/metis/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ vcpkg_from_github(OUT_SOURCE_PATH SOURCE_PATH
SHA512 c41168788c287ed9baea3c43c1ea8ef7d0bbdaa340a03cbbb5d0ba2d928d8a6dd83e2b77e7d3fabc58ac6d2b59a4be0492940e31460fe5e1807849cb98e80d2e
PATCHES
build-fixes.patch
build-fixes-gkregex.patch
)
file(COPY "${SOURCE_PATH}/include/" DESTINATION "${SOURCE_PATH}/build/xinclude")
file(COPY "${CMAKE_CURRENT_LIST_DIR}/install_config.cmake" DESTINATION "${SOURCE_PATH}")
Expand Down
1 change: 1 addition & 0 deletions ports/metis/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "metis",
"version-date": "2025-07-04",
"port-version": 1,
"description": "Serial Graph Partitioning and Fill-reducing Matrix Ordering",
"homepage": "https://github.com/KarypisLab/METIS",
"license": "Apache-2.0",
Expand Down
4 changes: 2 additions & 2 deletions versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3366,7 +3366,7 @@
},
"gklib": {
"baseline": "2025-07-06",
"port-version": 0
"port-version": 1
},
"gl2ps": {
"baseline": "1.4.2",
Expand Down Expand Up @@ -6326,7 +6326,7 @@
},
"metis": {
"baseline": "2025-07-04",
"port-version": 0
"port-version": 1
},
"metrohash": {
"baseline": "1.1.3",
Expand Down
5 changes: 5 additions & 0 deletions versions/g-/gklib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "5fcb778964e119e95b4b30606fcea8a3362d79c1",
"version-date": "2025-07-06",
"port-version": 1
},
{
"git-tree": "c3b9e3dbc3c508699816a7723c720428a478b364",
"version-date": "2025-07-06",
Expand Down
5 changes: 5 additions & 0 deletions versions/m-/metis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "b831f3b20149877e84f9101cc44ebb1ffe0e26f9",
"version-date": "2025-07-04",
"port-version": 1
},
{
"git-tree": "83d3f4ee2d498f9bc5d8f63b562744442c6065f1",
"version-date": "2025-07-04",
Expand Down