[gklib, metis] Add support for x64-mingw-dynamic#49865
Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom Feb 10, 2026
Merged
[gklib, metis] Add support for x64-mingw-dynamic#49865BillyONeal merged 2 commits intomicrosoft:masterfrom
BillyONeal merged 2 commits intomicrosoft:masterfrom
Conversation
I don't really know when regex library is needed. So I add it only for MinGW
BillyONeal
reviewed
Feb 10, 2026
| # Add compiler flags. | ||
| if(MSVC) | ||
| - set(GK_COPTIONS "-DWIN32 -DMSC -D_CRT_SECURE_NO_DEPRECATE -DUSE_GKREGEX") | ||
| + set(GK_COPTIONS "-DWIN32 -DMSC -D_CRT_SECURE_NO_DEPRECATE") |
Member
There was a problem hiding this comment.
Please submit this as a PR to https://github.com/KarypisLab/METIS/blob/master/conf/gkbuild.cmake
Contributor
Author
There was a problem hiding this comment.
BillyONeal
reviewed
Feb 10, 2026
| set(USE_GKREGEX ON) | ||
| + else() | ||
| + if(MINGW) | ||
| + target_link_libraries(${PROJECT_NAME} PUBLIC regex) |
Member
There was a problem hiding this comment.
Overloading the project name and a target name does not seem like a good idea to me but it is consistent with what upstream does ( https://github.com/KarypisLab/GKlib/blob/6e7951358fd896e2abed7887196b6871aac9f2f8/CMakeLists.txt#L50C1-L50C31 ); no change requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gklib needs regex to avoid undefined symbol about regex_t for target x64-mingw-dynamic
I also noticed that metis decided if
USE_GKREGEXneeds to be defined. It's wrong. gklib already does it../vcpkg x-add-version --alland committing the result.