-
Notifications
You must be signed in to change notification settings - Fork 41
Moved Format and Check to their own jobs to reduce mail notifications for deployment approval #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Removed task name from CI workflow job name.
gvanrossum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a big improvement already.
I wonder if we can get away with only a single job running the full tests (with secrets)? Then IMO that should be Python 3.14 on Ubuntu. Run the full 3x4 matrix without secrets, then just the one with secrets. Maybe for a follow-up PR? Or here if you like a challenge.
Another thing I'd like to try (definitely in a separate PR): Instead of having the jobs written out as uv run etc., use make check etc. on Ubuntu, and ./make.bat check on Windows. Then the exact list of source folders doesn't need to be hard-coded in ci.yml (since we always use the version from main).
Less jobs awaiting approval with this layout: